Bugzilla – Attachment 105432 Details for
Bug 25617
Error on about page when TimeFormat preference is set to 12hr
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25617: (QA follow-up) Add responses to tests
Bug-25617-QA-follow-up-Add-responses-to-tests.patch (text/plain), 1.91 KB, created by
Julian Maurice
on 2020-05-29 08:53:51 UTC
(
hide
)
Description:
Bug 25617: (QA follow-up) Add responses to tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2020-05-29 08:53:51 UTC
Size:
1.91 KB
patch
obsolete
>From c7f03dbe90dc7344a8df8b6391098f171316a19d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 28 May 2020 17:37:20 +0000 >Subject: [PATCH] Bug 25617: (QA follow-up) Add responses to tests > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > t/DateUtils.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/DateUtils.t b/t/DateUtils.t >index b7cd33c044..5248997058 100755 >--- a/t/DateUtils.t >+++ b/t/DateUtils.t >@@ -270,17 +270,17 @@ subtest 'TimeFormat 12hr' => sub { > t::lib::Mocks::mock_preference('TimeFormat', '12hr'); > my $output = output_pref({ dt => $dt, dateformat => 'iso' }); > $dt = dt_from_string( $output, 'iso' ); >- is( output_pref( {dt => $dt} ), '28/05/2020 12:49 PM' ); >+ is( output_pref( {dt => $dt} ), '28/05/2020 12:49 PM', "12 NOON formatted correctly in 12hr format" ); > t::lib::Mocks::mock_preference('TimeFormat', '24hr'); >- is( output_pref( {dt => $dt} ), '28/05/2020 12:49' ); >+ is( output_pref( {dt => $dt} ), '28/05/2020 12:49' , "12 NOON formatted correctly in 24hr format" ); > > $dt = DateTime->new( year => 2020, month => 5, day => 28, hour => 0, minute => 49 ); > t::lib::Mocks::mock_preference('TimeFormat', '12hr'); > $output = output_pref({ dt => $dt, dateformat => 'iso' }); > $dt = dt_from_string( $output, 'iso' ); >- is( output_pref( {dt => $dt} ), '28/05/2020 12:49 AM' ); >+ is( output_pref( {dt => $dt} ), '28/05/2020 12:49 AM', "12 MIDNIGHT formatted correctly in 12hr format" ); > t::lib::Mocks::mock_preference('TimeFormat', '24hr'); >- is( output_pref( {dt => $dt} ), '28/05/2020 00:49' ); >+ is( output_pref( {dt => $dt} ), '28/05/2020 00:49', "12 MIDNIGHT formatted correctly in 24hr format" ); > }; > > # output_pref with no parameters, single parameter (no hash) >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25617
:
105412
|
105417
|
105418
|
105422
|
105423
|
105431
| 105432