From 3c0440b16216ebf4399d7e0bdfa5a520ac6a05f9 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Sun, 31 May 2020 15:54:08 +0200
Subject: [PATCH] Bug 25630: Fix capitalization and terminology for Staff
 interface system preferences

This changes "staff client" to "staff interface" and fixes capitalization
in a couple of cases.

For terminology changes see:
https://wiki.koha-community.org/wiki/Terminology#S

To test:
- Read through the preferences of the "staff interface" tab.
- Staff interface should be used consistently.
- Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's
  own terminology.
---
 .../intranet-tmpl/prog/en/includes/prefs-menu.inc  |  2 +-
 .../en/modules/admin/preferences/staff_client.pref | 36 +++++++++++-----------
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
index 542cf1f19e..0e8f4eb1d6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
@@ -14,7 +14,7 @@
 [% IF ( patrons ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Patrons" href="/cgi-bin/koha/admin/preferences.pl?tab=patrons">Patrons</a></li>
 [% IF ( searching ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Searching" href="/cgi-bin/koha/admin/preferences.pl?tab=searching">Searching</a></li>
 [% IF ( serials ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Serials" href="/cgi-bin/koha/admin/preferences.pl?tab=serials">Serials</a></li>
-[% IF ( staff_client ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Staff client" href="/cgi-bin/koha/admin/preferences.pl?tab=staff_client">Staff client</a></li>
+[% IF ( staff_client ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Staff interface" href="/cgi-bin/koha/admin/preferences.pl?tab=staff_client">Staff client</a></li>
 [% IF ( tools ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Tools" href="/cgi-bin/koha/admin/preferences.pl?tab=tools">Tools</a></li>
 [% IF ( web_services ) %]<li class="active">[% ELSE %]<li>[% END %]<a title="Web services" href="/cgi-bin/koha/admin/preferences.pl?tab=web_services">Web services</a></li>
 </ul>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
index f24655be49..c19cf38949 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
@@ -1,4 +1,4 @@
-Staff Client:
+Staff interface:
     Appearance:
         -
             - "Display language selector on "
@@ -13,7 +13,7 @@ Staff Client:
               choices: staff-templates
             - theme on the staff interface.
         -
-            - "The staff client is located at"
+            - "The staff interface is located at"
             - pref: staffClientBaseURL
               class: url
             - This should be a complete URL, starting with http:// or https://. Do not include a trailing slash in the URL. (This must be filled in correctly for CAS, svc, and load_testing to work.)
@@ -23,13 +23,13 @@ Staff Client:
               class: url
             - on all pages in the staff interface, instead of the default css (used when leaving this field blank). Enter just a filename, a full local path or a complete URL starting with <code>http://</code> (if the file lives on a remote server). Please note that if you just enter a filename, the file should be in the css subdirectory for each active theme and language within the Koha templates directory. A full local path is expected to start from your HTTP document root.
         -
-            - "Use the following JavaScript for printing slips. See detailed description on the <a href='https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently'>Koha Wiki</a> and eventually Firefox PlugIn <a href='https://github.com/edabg/jsprintsetup/wiki'>jsPrintSetup documentation</a>:"
+            - "Use the following JavaScript for printing slips. See detailed description on the <a href='https://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently'>Koha Wiki</a> and eventually Firefox add-on <a href='https://github.com/edabg/jsprintsetup/wiki'>jsPrintSetup documentation</a>:"
             - pref: IntranetSlipPrinterJS
               type: textarea
               syntax: javascript
               class: code
         -
-            - "Include the following CSS on all pages in the staff client:"
+            - "Include the following CSS on all pages in the staff interface:"
             - pref: IntranetUserCSS
               type: textarea
               syntax: css
@@ -45,19 +45,19 @@ Staff Client:
               class: file
             - directory in the template directory, instead of <code>includes/</code>. (Leave blank to disable)
         -
-            - "Show the following HTML in its own column on the main page of the staff client:"
+            - "Show the following HTML in its own column on the main page of the staff interface:"
             - pref: IntranetmainUserblock
               type: textarea
               syntax: text/html
               class: code
         -
-            - "Show the following HTML to the left of the More menu at the top of each page on the staff client (should be a list of links or blank):"
+            - "Show the following HTML to the left of the More menu at the top of each page on the staff interface (should be a list of links or blank):"
             - pref: IntranetNav
               type: textarea
               syntax: html
               class: code
         -
-            - "Include the following JavaScript on all pages in the staff client:"
+            - "Include the following JavaScript on all pages in the staff interface:"
             - pref: IntranetUserJS
               type: textarea
               syntax: javascript
@@ -66,19 +66,19 @@ Staff Client:
             - Use the image at
             - pref: IntranetFavicon
               class: url
-            - for the Staff Client's favicon. (This should be a complete URL, starting with <code>http://</code>.)
+            - for the Staff interface's favicon. (This should be a complete URL, starting with <code>http://</code>.)
         -
-            - 'Display lists in the staff client using XSLT stylesheet at: '
+            - 'Display lists in the staff interface using XSLT stylesheet at: '
             - pref: XSLTListsDisplay
               class: file
             - '<br />Options:<ul><li><a href="#" class="set_syspref" data-syspref="XSLTListsDisplay" data-value="">Leave empty</a> for "no xslt"</li><li>enter "<a href="#" class="set_syspref" data-syspref="XSLTListsDisplay" data-value="default">default</a>" for the default one</li><li> put a path to define a xslt file</li><li>put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
         -
-            - 'Display results in the staff client using XSLT stylesheet at: '
+            - 'Display results in the staff interface using XSLT stylesheet at: '
             - pref: XSLTResultsDisplay
               class: file
             - '<br />Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTResultsDisplay" data-value="default">default</a>" for the default one</li><li>Put a path to define a xslt file</li><li>Put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
         -
-            - 'Display details in the staff client using XSLT stylesheet at: '
+            - 'Display details in the staff interface using XSLT stylesheet at: '
             - pref: XSLTDetailsDisplay
               class: file
             - '<br />Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTDetailsDisplay" data-value="default">default</a>" for the default one</li><li>Put a path to define a xslt file</li><li>Put an URL for an external specific stylesheet.</li></ul>{langcode} will be replaced with current interface language'
@@ -87,7 +87,7 @@ Staff Client:
               choices:
                   yes: Show
                   no: "Don't show"
-            - the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in the staff client.
+            - the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in the staff interface.
         -
             - 'Display the URI in the 856u field as an image on: '
             - pref: Display856uAsImage
@@ -115,7 +115,7 @@ Staff Client:
               syntax: text/html
               class: code
         -
-            - "Show the following HTML on the staff client login page"
+            - "Show the following HTML on the staff interface login page"
             - pref: StaffLoginInstructions
               type: textarea
               syntax: text/html
@@ -126,19 +126,19 @@ Staff Client:
               choices:
                   yes: Allow
                   no: "Don't allow"
-            - staff to view records in plain MARC form on the staff client.
+            - staff to view records in plain MARC form on the staff interface.
         -
             - pref: viewLabeledMARC
               choices:
                   yes: Allow
                   no: "Don't allow"
-            - staff to view records in labeled MARC form on the staff client.
+            - staff to view records in labeled MARC form on the staff interface.
         -
             - pref: viewISBD
               choices:
                   yes: Allow
                   no: "Don't allow"
-            - staff to view records in ISBD form on the staff client.
+            - staff to view records in ISBD form on the staff interface.
         -
             - pref: HidePatronName
               choices:
@@ -150,13 +150,13 @@ Staff Client:
               choices:
                   no: "Don't show"
                   yes: Show
-            - a link to the last searched patron in the staff client.
+            - a link to the last searched patron in the staff interface.
         -
             - pref: intranetbookbag
               choices:
                   yes: Show
                   no: "Don't show"
-            - the cart option in the staff client.
+            - the cart option in the staff interface.
         -
             - pref: StaffDetailItemSelection
               choices:
-- 
2.11.0