Bugzilla – Attachment 105738 Details for
Bug 25507
PDF order print for German 2-pages is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25507: Fix table in basket group PDF German 2-pages
Bug-25507-Fix-table-in-basket-group-PDF-German-2-p.patch (text/plain), 1.78 KB, created by
Martin Renvoize
on 2020-06-11 11:51:40 UTC
(
hide
)
Description:
Bug 25507: Fix table in basket group PDF German 2-pages
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-06-11 11:51:40 UTC
Size:
1.78 KB
patch
obsolete
>From 9455b3fd4e1021e6237d7befe0ff3c5596b924f3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 23 May 2020 01:22:53 +0200 >Subject: [PATCH] Bug 25507: Fix table in basket group PDF German 2-pages > >A variable was doubled up which made the columns in the >table of orders no longer line up (different number of headers >to columns). > >To test: >- Create at least one basket with one or more orders >- Close the basket >- Add the basket to a basket group manually or let Koha do it > on closing >- Change the OrderPdfFormat system preference to 'German 2-page' >- Go to the basket group page and print the PDF of the basket >- Verify the table of orders doesn't look right and runs outside > the page >- Apply patch >- Repeat the PDF print - now table should look right > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/pdfformat/layout2pagesde.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/pdfformat/layout2pagesde.pm b/Koha/pdfformat/layout2pagesde.pm >index aeee17bd4a..94f520c919 100644 >--- a/Koha/pdfformat/layout2pagesde.pm >+++ b/Koha/pdfformat/layout2pagesde.pm >@@ -92,7 +92,7 @@ sub printorders { > } > push( @$arrbasket, > $basket->{basketno}, >- $titleinfo. ($line->{order_vendornote} ? "\n----------------\nLieferantennotiz : ". $line->{order_vendornote} : '' ), $line->{quantity}, >+ $titleinfo. ($line->{order_vendornote} ? "\n----------------\nLieferantennotiz : ". $line->{order_vendornote} : '' ), > $line->{quantity}, > Koha::Number::Price->new( $line->{rrp_tax_included} )->format, > Koha::Number::Price->new( $line->{discount} )->format . '%', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25507
:
105295
|
105674
| 105738