From cc42336aaad0910e7996f4db4a732671d0d5ec7a Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Fri, 12 Jun 2020 13:51:16 +0000 Subject: [PATCH] Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit Signed-off-by: donnab --- circ/pendingreserves.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index 7f2062942a..b95d92ef41 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -223,7 +223,7 @@ my $strsth = $sqldatewhere AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber) AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where datearrived IS NULL) - AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL) + AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL AND itemnumber IS NOT NULL) AND issues.itemnumber IS NULL AND reserves.priority <> 0 AND reserves.suspend = 0 -- 2.11.0