From 3a6e53a0e6505bef440e04798282ddbc3702e6f8 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 23 Jun 2020 11:52:20 +0000
Subject: [PATCH] Bug 25832: Add DataTables to MARC subfield structure admin
 page for authorities

This patch adds DataTables sorting and filtering to the table of
subfields shown on the Authority MARC subfield structure administration
page.

To test, apply the patch and go to Administration -> Authority types.

 - From the 'Actions' menu, select 'MARC structure.'
 - From the 'Actions' menu, select the 'Subfields' link for a tag
   with multiple subfields.
   - On the page showing all the subfields for the tag, confirm that
     the table is sorted by default by subfield and that sorting works
     correctly.
   - Confirm that the search form at the top of the table works.
---
 .../en/modules/admin/auth_subfields_structure.tt   | 31 +++++++++++++++-------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
index b5da79e661..b54246d678 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
@@ -263,13 +263,16 @@
 <p>This screen shows the subfields associated with the selected tag. You can edit subfields or add a new one by clicking on edit.</p>
 <p>The column 'Koha field' shows that the subfield is linked with a Koha field.</p>
 
-<table>
-    <tr>
-        <th>Subfield</th>
-        <th>Text</th>
-        <th>Constraints</th>
-        <th>&nbsp;</th>
-    </tr>
+<table id="table_authsubfieldstructure">
+    <thead>
+        <tr>
+            <th>Subfield</th>
+            <th>Text</th>
+            <th>Constraints</th>
+            <th class="NoSort">&nbsp;</th>
+        </tr>
+    </thead>
+    <tbody>
     [% FOREACH loo IN loop %]
     <tr>
         <td>[% loo.tagsubfield | html %]</td>
@@ -304,6 +307,7 @@
         <td><a href="?op=delete_confirm&amp;tagfield=[% loo.tagfield | uri %]&amp;tagsubfield=[% loo.tagsubfield | uri %]&amp;authtypecode=[% authtypecode | uri %]" class="btn btn-default btn-xs"><i class="fa fa-trash"></i> Delete</a></td>
     </tr>
     [% END %]
+    </tbody>
 </table>
 
     <form action="[% script_name | html %]" method="get">
@@ -337,11 +341,18 @@
      </div> <!-- /.row -->
 
 [% MACRO jsinclude BLOCK %]
+    [% INCLUDE 'datatables.inc' %]
     [% Asset.js("js/admin-menu.js") | $raw %]
     <script>
-     $(document).ready(function() {
-        $('#subfieldtabs').tabs();
-     });
+        $(document).ready(function() {
+            $('#subfieldtabs').tabs();
+            $("#table_authsubfieldstructure").dataTable($.extend(true, {}, dataTablesDefaults, {
+                "columnDefs": [
+                    { 'sortable': false, 'targets': [ 'NoSort' ] }
+                ],
+                paginate: false
+            }));
+        });
     </script>
 [% END %]
 [% INCLUDE 'intranet-bottom.inc' %]
-- 
2.11.0