Bugzilla – Attachment 10632 Details for
Bug 5981
OPAC: Add limits to search history
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history
0001-Bug-5981-OPAC-Add-limits-to-search-history.patch (text/plain), 2.58 KB, created by
Jonathan Druart
on 2012-07-04 12:50:50 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-04 12:50:50 UTC
Size:
2.58 KB
patch
obsolete
>From 7b0ee4d5949c2668b72ecc71742fcaf278c34f17 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Sun, 10 Jun 2012 13:14:24 +0200 >Subject: [PATCH 1/1] Bug 5981 - OPAC: Add limits to search history > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch. > >Patch works nicely, tested with different searches and limits. > >Note: Sort options don't get into the history still. >--- > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 7 +++++++ > opac/opac-search.pl | 6 ++++++ > 3 files changed, 14 insertions(+), 1 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index e1105a5..593c404 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1746,7 +1746,7 @@ CREATE TABLE IF NOT EXISTS `search_history` ( > `userid` int(11) NOT NULL, > `sessionid` varchar(32) NOT NULL, > `query_desc` varchar(255) NOT NULL, >- `query_cgi` varchar(255) NOT NULL, >+ `query_cgi` text NOT NULL, > `total` int(11) NOT NULL, > `time` timestamp NOT NULL default CURRENT_TIMESTAMP, > KEY `userid` (`userid`), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 4da22e7..9563de0 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -5452,6 +5452,13 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.09.00.XXX"; >+if (C4::Context->preference("Version") < TransformToNum($DBversion)) { >+ $dbh->do("ALTER TABLE search_history MODIFY COLUMN query_cgi text NOT NULL"); >+ print "Upgrade to $DBversion done (Change search_history.query_cgi type to text. bug 5981)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 7eeebbd..404b48d 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -589,6 +589,12 @@ for (my $i=0;$i<@servers;$i++) { > } > > # Adding the new search if needed >+ my $path_info = $cgi->url(-path_info=>1); >+ $query_cgi = $cgi->url(-query=>1); >+ $query_cgi =~ s/^$path_info\?//; >+ $query_cgi =~ s/;/&/g; >+ $query_desc .= ", $limit_desc"; >+ > if (!$borrowernumber || $borrowernumber eq '') { > # To a cookie (the user is not logged in) > if (($params->{'offset'}||'') eq '') { >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5981
:
3485
|
3657
|
4798
|
4860
|
5277
|
5422
|
5659
|
10087
|
10316
| 10632