Bugzilla – Attachment 106362 Details for
Bug 25697
Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25697: Declare base url and suffix in tinymce init
Bug-25697-Declare-base-url-and-suffix-in-tinymce-i.patch (text/plain), 3.46 KB, created by
Katrin Fischer
on 2020-06-28 21:32:52 UTC
(
hide
)
Description:
Bug 25697: Declare base url and suffix in tinymce init
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-06-28 21:32:52 UTC
Size:
3.46 KB
patch
obsolete
>From 93f46cddd6c0a91f2c61f26e15e4f2fc71a1621f Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 9 Jun 2020 15:54:04 +1000 >Subject: [PATCH] Bug 25697: Declare base url and suffix in tinymce init > >This patch declares the base url and suffix in tinymce init, so >that tinymce will initialize properly cross-browser. Without this change, >tinymce will fail to initialize on IE 11. > >Test plan: >0. Apply patch >1. Open IE 11 >2. Enable "UseWYSIWYGinSystemPreferences" system preference >3. Go to /cgi-bin/koha/admin/preferences.pl?tab=opac and note that >tinymce initializes correctly >4. Go to /cgi-bin/koha/tools/koha-news.pl and create/edit a news item, >and note that tinymce initializes correctly >5. Go to /cgi-bin/koha/admin/branches.pl and add/edit a library, and >note that tinymce initializes correctly for "OPAC info" > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt | 3 +++ > 3 files changed, 9 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >index bcfd0f1648..386a577eed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc >@@ -14,6 +14,9 @@ > > tinyMCE.init({ > branding : false, >+ //suffix and base_url required for IE 11 >+ suffix: '.min', >+ base_url: "[% interface | html %]/lib/tiny_mce", > content_css : "[% interface | html %]/[% theme | html %]/css/tinymce.css", > editor_selector : "mce", > menubar : "file edit view insert format tools table", >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index bda80a8407..c030a64491 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -387,6 +387,9 @@ > > tinyMCE.init({ > branding : false, >+ //suffix and base_url required for IE 11 >+ suffix: '.min', >+ base_url: "[% interface | html %]/lib/tiny_mce", > content_css : "[% interface | html %]/[% theme | html %]/css/tinymce.css", > menubar : "file edit view insert format tools table", > mode : "specific_textareas", >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >index 062f0e1642..6423c30fb7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >@@ -301,6 +301,9 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div> > force_p_newlines : false, > forced_root_block : '', > branding : false, >+ //suffix and base_url required for IE 11 >+ suffix: '.min', >+ base_url: "[% interface | html %]/lib/tiny_mce", > content_css : "[% interface | html %]/[% theme | html %]/css/tinymce.css", > menubar : "file edit view insert format tools table", > mode : "specific_textareas", >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25697
:
105655
|
106174
|
106208
| 106362