Bugzilla – Attachment 106493 Details for
Bug 25726
Holds to Pull made empty by pathological holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null
Bug-25726-make-holds-to-pull-ignore-holds-where-fo.patch (text/plain), 2.07 KB, created by
Marcel de Rooy
on 2020-07-03 09:38:27 UTC
(
hide
)
Description:
Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-07-03 09:38:27 UTC
Size:
2.07 KB
patch
obsolete
>From d9a01f136bbac88e5eef40ac37f0589305c4616f Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Date: Fri, 12 Jun 2020 13:51:16 +0000 >Subject: [PATCH] Bug 25726: make holds to pull ignore holds where found is not > null and itemnumber is null >Content-Type: text/plain; charset=utf-8 > >To test: >1- place 2 bib-level holds on available items >2- confirm they both show on Holds to Pull >3- edit one hold from the database to set found='T' >4- reload Holds to Pull, confirm it is now empty >5- apply patch >6- Reload Holds to Pull >7- confirm it now shows the hold you did not edit > >Signed-off-by: donnab <donna@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] Using capitals for SQL reserved words; added a FIXME >Tested with: > update reserves set found='T', itemnumber=NULL where reserve_id=... >This should be a workaround while we fix the underlying problem. >--- > circ/pendingreserves.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 22c93f7130..ea78061fe2 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -224,7 +224,7 @@ my $strsth = > $sqldatewhere > AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber) > AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where datearrived IS NULL) >- AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL) >+ AND items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE found IS NOT NULL AND itemnumber IS NOT NULL) > AND issues.itemnumber IS NULL > AND reserves.priority <> 0 > AND reserves.suspend = 0 >@@ -233,7 +233,7 @@ my $strsth = > "; > # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when > # multiple patrons have a hold on an item >- >+#FIXME "found IS NOT NULL AND itemnumber IS NOT NULL" is just a workaround: see BZ 25726 > > if (C4::Context->preference('IndependentBranches')){ > $strsth .= " AND items.holdingbranch=? "; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25726
:
105800
|
105821
| 106493