From 6a5afddaca1fda1714f23f6f1a318c9fcd4bb2d8 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Sat, 11 Jul 2020 12:09:49 +0000 Subject: [PATCH] Bug 25906: Style corrections for OPAC serial pages This patch makes some CSS changes to the OPAC SCSS and to the OPAC "full serial issues" page to improve the style. I've expanded the in-page CSS on the full serial issues page for readability and added Template Toolkit's "collapse" filter to remove the whitespace on rendering. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Locate a serial record in the OPAC. - Click "More details" to view the issues page. - Confirm that the "view" tabs look correct, with consistent padding. - Click the "Full history" tab. - In the sidebar, the filter should have full-width dropdowns and clear button. --- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 7 +--- .../en/modules/opac-full-serial-issues.tt | 49 ++++++++++++++++++++-- .../bootstrap/en/modules/opac-serial-issues.tt | 9 +++- 3 files changed, 53 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index c30901390e..66021a4656 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -1460,6 +1460,7 @@ div { font-size: 14px; line-height: 20px; text-align: center; + text-decoration: none; vertical-align: middle; } } @@ -1475,12 +1476,6 @@ div { font-weight: bold; } -#Fullhistory, -#Briefhistory { - background: transparent none; - padding-left: 0; -} - /* pagination */ .pagination { diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt index 42d63dd77a..b4f5aa574d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt @@ -5,9 +5,50 @@ [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Full subscription history for [% bibliotitle | html %] [% INCLUDE 'doc-head-close.inc' %] [% BLOCK cssinclude %] + [% FILTER collapse %] + [% END %] [% END %] [% INCLUDE 'bodytag.inc' bodyid='opac-full-serial-issues' bodyclass='scrollto' %] @@ -30,12 +71,12 @@ diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt index 4be2764a6b..27d5e1f756 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt @@ -2,7 +2,12 @@ [% INCLUDE 'doc-head-open.inc' %] [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Issues for a subscription [% INCLUDE 'doc-head-close.inc' %] -[% BLOCK cssinclude %][% END %] +[% BLOCK cssinclude %] + .subscriptionline { + border-bottom: 1px solid #EEE; + padding: 1em 0; + } +[% END %] [% INCLUDE 'bodytag.inc' bodyid='opac-serials-issues' %] [% INCLUDE 'masthead.inc' %] @@ -37,7 +42,7 @@
[% FOREACH subscription_LOO IN subscription_LOOP %] -
+

Subscription information for [% subscription_LOO.bibliotitle | html %]

The current subscription began on [% subscription_LOO.startdate | html %] and is issued -- 2.11.0