Bugzilla – Attachment 106933 Details for
Bug 25992
SIP2 server doesn't start - Undefined subroutine set_logger
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25992: Make SIP2 logger subroutines exportable to prevent crash
Bug-25992-Make-SIP2-logger-subroutines-exportable-.patch (text/plain), 1.34 KB, created by
Tomás Cohen Arazi
on 2020-07-15 12:46:52 UTC
(
hide
)
Description:
Bug 25992: Make SIP2 logger subroutines exportable to prevent crash
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2020-07-15 12:46:52 UTC
Size:
1.34 KB
patch
obsolete
>From a727cc586212723224dac120de21081668f4fec2 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 15 Jul 2020 11:08:32 +0000 >Subject: [PATCH] Bug 25992: Make SIP2 logger subroutines exportable to prevent > crash > >If the subroutines are not exportable we get the following crash: > >> Undefined subroutine &C4::SIP::SIPServer::set_logger > >To test: > In kohadevbox run for example: > $ ps -aux # check that no existing sip server is running, kill the process if exists > $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml > $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information > > After applying this patch the Undefined subroutine error should be gone. > Note: when using the sip_cli_emulator.pl the credentials can be anything. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/SIP/Logger.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/SIP/Logger.pm b/C4/SIP/Logger.pm >index 41169219d1d..c73886cdc71 100644 >--- a/C4/SIP/Logger.pm >+++ b/C4/SIP/Logger.pm >@@ -3,6 +3,9 @@ package C4::SIP::Logger; > > use Modern::Perl; > >+use base 'Exporter'; >+our @EXPORT_OK = qw ( get_logger set_logger ); >+ > our $activeSIPServer; > our $activeLogger; > >-- >2.27.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25992
:
106928
|
106929
| 106933