Bugzilla – Attachment 107099 Details for
Bug 24379
Patron login attempts happen to be NULL instead of 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24379: Fix failing tests
Bug-24379-Fix-failing-tests.patch (text/plain), 2.64 KB, created by
Jonathan Druart
on 2020-07-20 13:17:02 UTC
(
hide
)
Description:
Bug 24379: Fix failing tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-07-20 13:17:02 UTC
Size:
2.64 KB
patch
obsolete
>From d8458f64bcea24d853230421311506a8b8184bf0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 20 Jul 2020 15:16:29 +0200 >Subject: [PATCH] Bug 24379: Fix failing tests > >kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons/Import.t >t/db_dependent/Koha/Patrons/Import.t .. 2/159 > # Failed test 'No warning raised by import_patrons' > # at t/db_dependent/Koha/Patrons/Import.t line 171. > # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. > # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. > # didn't expect to find a warning >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2. >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2. >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2. >Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2. >t/db_dependent/Koha/Patrons/Import.t .. 152/159 # Looks like you failed 1 test of 159. >t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 1 (wstat 256, 0x100) >Failed 1/159 subtests > >Test Summary Report >------------------- >t/db_dependent/Koha/Patrons/Import.t (Wstat: 256 Tests: 159 Failed: 1) > Failed test: 39 > Non-zero exit status: 1 >Files=1, Tests=159, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.11 cusr 0.24 csys = 2.40 CPU) >Result: FAIL >--- > Koha/Patrons/Import.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index 56b18023ce..7839c4fb85 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -231,7 +231,7 @@ sub import_patrons { > # Remove warning for int datatype that cannot be null > # Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 > for my $field ( >- qw( privacy privacy_guarantor_fines privacy_guarantor_checkouts anonymized )) >+ qw( privacy privacy_guarantor_fines privacy_guarantor_checkouts anonymized login_attempts )) > { > delete $borrower{$field} > if exists $borrower{$field} and $borrower{$field} eq ""; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24379
:
97058
|
97073
|
105522
|
106846
|
106847
|
106890
| 107099