From 6df1ef7607a102a9aaf8a1d66bdde0bc5b97f722 Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Sun, 8 Jul 2012 22:06:28 -0400 Subject: [PATCH] Bug 8383: Add test to check that Perl scripts compile Content-Type: text/plain; charset="UTF-8" This patch adds t/db_dependent/00-strict.pl which tests that all Perl scripts compile. I chose to use Test::Strict so that in the future we can also have the test check that "use strict" and "use warnings" are enabled. To test: 1. Run t/db_dependent/00-strict.pl. 2. Run around waving your arms in the air that we have a couple of scripts that don't compile. 3. Actually, that's about it. You could test my patch for bug 8384 next. Signed-off-by: Jared Camins-Esakov Moved test to t/db_dependent --- C4/Installer/PerlDependencies.pm | 4 ++++ debian/control | 1 + t/db_dependent/00-strict.t | 24 ++++++++++++++++++++++++ 3 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 t/db_dependent/00-strict.t diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 2391b0b..cc10c9a 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -573,6 +573,10 @@ our $PERL_DEPS = { 'usage' => 'Core', 'required' => '0', 'min_ver' => '0.05', + }, + 'Test::Strict' => { + 'usage' => 'Core', + 'required' => '0.14', } }; diff --git a/debian/control b/debian/control index 588c641..334b63a 100644 --- a/debian/control +++ b/debian/control @@ -68,6 +68,7 @@ Build-Depends: libcgi-session-driver-memcached-perl, libsms-send-perl, libtemplate-perl, libtest-simple-perl | perl-modules, + libtest-strict-perl, libtext-csv-encoded-perl, libtext-csv-perl, libtext-csv-xs-perl, diff --git a/t/db_dependent/00-strict.t b/t/db_dependent/00-strict.t new file mode 100644 index 0000000..7869591 --- /dev/null +++ b/t/db_dependent/00-strict.t @@ -0,0 +1,24 @@ +# This script is called by the pre-commit git hook to test modules compile + +use strict; +use warnings; +use Test::More; +use Test::Strict; +use File::Spec; +use File::Find; +use lib("misc/translator"); +use lib("installer"); + +my @dirs = ( 'acqui', 'admin', 'authorities', 'basket', + 'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs', + 'edithelp.pl', 'errors', 'fix-perl-path.PL', 'help.pl', 'installer', + 'koha_perl_deps.pl', 'kohaversion.pl', 'labels', + 'mainpage.pl', 'Makefile.PL', 'members', 'misc', 'offline_circ', 'opac', + 'patroncards', 'reports', 'reserve', 'resetversion.pl', 'reviews', + 'rewrite-config.PL', 'rotating_collections', 'serials', 'services', 'skel', + 'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' ); + +$Test::Strict::TEST_STRICT = 0; +$Test::Strict::TEST_SKIP = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl' ]; + +all_perl_files_ok(@dirs); -- 1.7.2.5