From 269dff24e4d2bb3a3a6555aeb593400c656d9bea Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 22 Jul 2020 14:11:03 +0200 Subject: [PATCH] Bug 26043: Fix random failure from Holds.t # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 202. # got: undef # expected: '1605' # Looks like you failed 1 test of 66. It is coming from Koha::Patron->holds that is ordering by reservedate, so "sometimes" they are ordered in reverse (at least it's my understanding of the problem). Test plan: Run the test file several times (from 20 to 60x), it must never fail with this patch --- t/db_dependent/Holds.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index bf9540573c..37da7b05f7 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -199,7 +199,7 @@ $holds = $patron->holds; my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $borrowernumbers[0] })->next->reserve_id; ModReserveMinusPriority( $itemnumber, $reserveid ); $holds = $patron->holds; -is( $holds->next->itemnumber, $itemnumber, "Test ModReserveMinusPriority()" ); +is( $holds->search({ itemnumber => $itemnumber })->count, 1, "Test ModReserveMinusPriority()" ); $holds = $biblio->holds; $hold = $holds->next; -- 2.20.1