View | Details | Raw Unified | Return to bug 24446
Collapse All | Expand All

(-)a/Koha/Item/Transfer.pm (+13 lines)
Lines 82-87 sub transit { Link Here
82
82
83
    ModDateLastSeen( $self->item->itemnumber );
83
    ModDateLastSeen( $self->item->itemnumber );
84
    return $self;
84
    return $self;
85
86
}
87
88
=head3 in_transit
89
90
Boolean returning whether the transfer is in transit or waiting
91
92
=cut
93
94
sub in_transit {
95
    my ($self) = @_;
96
97
    return ( defined( $self->datesent ) && !defined( $self->datearrived ) );
85
}
98
}
86
99
87
=head3 receipt
100
=head3 receipt
(-)a/t/db_dependent/Koha/Item/Transfer.t (-2 / +37 lines)
Lines 23-29 use Koha::Database; Link Here
23
23
24
use t::lib::TestBuilder;
24
use t::lib::TestBuilder;
25
25
26
use Test::More tests => 3;
26
use Test::More tests => 4;
27
use Test::Exception;
27
use Test::Exception;
28
28
29
my $schema  = Koha::Database->new->schema;
29
my $schema  = Koha::Database->new->schema;
Lines 167-171 subtest 'receipt tests' => sub { Link Here
167
    # Last seen
167
    # Last seen
168
    ok( $item->datelastseen, 'Receipt set item datelastseen date' );
168
    ok( $item->datelastseen, 'Receipt set item datelastseen date' );
169
169
170
    $schema->storage->txn_rollback;
171
};
172
173
subtest 'in_transit tests' => sub {
174
175
    plan tests => 3;
176
177
    $schema->storage->txn_begin;
178
179
    my $library_from = $builder->build_object( { class => 'Koha::Libraries' } );
180
    my $library_to   = $builder->build_object( { class => 'Koha::Libraries' } );
181
    my $item     = $builder->build_sample_item(
182
        {
183
            homebranch    => $library_to->branchcode,
184
            holdingbranch => $library_from->branchcode,
185
        }
186
    );
187
188
    my $transfer = Koha::Item::Transfer->new(
189
        {
190
            itemnumber    => $item->itemnumber,
191
            frombranch    => $library_from->branchcode,
192
            tobranch      => $library_to->branchcode,
193
            daterequested => dt_from_string,
194
        }
195
    )->store;
196
197
    ok( !$transfer->in_transit, 'in_transit returns false when only daterequested is defined' );
198
199
    $transfer->datesent(dt_from_string)->store;
200
    ok( $transfer->in_transit, 'in_transit returns true when datesent is defined');
201
202
    $transfer->datearrived(dt_from_string)->store;
203
    ok( !$transfer->in_transit, 'in_transit returns false when datearrived is defined');
204
205
170
    $schema->storage->txn_rollback;
206
    $schema->storage->txn_rollback;
171
};
207
};
172
- 

Return to bug 24446