Bugzilla – Attachment 107416 Details for
Bug 25729
Charges/Fees.t is failing on slow servers due to wrong date comparison
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25729: Prevent Charges/Fees.t to fail on slow server
Bug-25729-Prevent-ChargesFeest-to-fail-on-slow-ser.patch (text/plain), 1.07 KB, created by
Jonathan Druart
on 2020-07-27 13:16:58 UTC
(
hide
)
Description:
Bug 25729: Prevent Charges/Fees.t to fail on slow server
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-07-27 13:16:58 UTC
Size:
1.07 KB
patch
obsolete
>From c9a82669f91e2b85753e5d5a5c77ed634ffd21e0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 27 Jul 2020 15:15:44 +0200 >Subject: [PATCH] Bug 25729: Prevent Charges/Fees.t to fail on slow server > >We must use t::lib::Dates::compare to compare dates > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Koha/Charges/Fees.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Charges/Fees.t b/t/db_dependent/Koha/Charges/Fees.t >index a204521b9a..637aaa278f 100644 >--- a/t/db_dependent/Koha/Charges/Fees.t >+++ b/t/db_dependent/Koha/Charges/Fees.t >@@ -25,6 +25,7 @@ use Test::Warn; > > use t::lib::Mocks; > use t::lib::TestBuilder; >+use t::lib::Dates; > > use Time::Fake; > use C4::Calendar; >@@ -198,7 +199,7 @@ subtest 'new' => sub { > to_date => $dt_to, > } > ); >- is( $fees->from_date, dt_from_string(), >+ is( t::lib::Dates::compare($fees->from_date, dt_from_string()), 0, > 'from_date default set correctly to today' ); > }; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25729
: 107416