From 4715d7ba6ee946209a7a5648a48971a90a969574 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Wed, 29 Jul 2020 13:23:14 +0100 Subject: [PATCH] Bug 26082 - Call store on new items to update itemnumber Need to add call to store to Koha::Item->new so that itemnumber is returned - otherwise is not defined and causes an error Bug is a side-effect of Bug 23463 as this was implicitly done in AddItem --- Koha/EDI.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/EDI.pm b/Koha/EDI.pm index a692da146b..136a0cd52a 100644 --- a/Koha/EDI.pm +++ b/Koha/EDI.pm @@ -719,7 +719,7 @@ sub quote_item { my $created = 0; while ( $created < $order_quantity ) { $item_hash->{biblionumber} = $bib->{biblionumber}; - my $item = Koha::Item->new( $item_hash ); + my $item = Koha::Item->new( $item_hash )->store; my $itemnumber = $item->itemnumber; $logger->trace("Added item:$itemnumber"); $schema->resultset('AqordersItem')->create( @@ -810,7 +810,7 @@ sub quote_item { } $item_hash->{biblionumber} = $bib->{biblionumber}; - my $item = Koha::Item->new( $item_hash ); + my $item = Koha::Item->new( $item_hash )->store; my $itemnumber = $item->itemnumber; $logger->trace("New item $itemnumber added"); $schema->resultset('AqordersItem')->create( @@ -879,7 +879,7 @@ sub quote_item { homebranch => $item->girfield( 'branch', $occurrence ), }; $new_item->{biblionumber} = $bib->{biblionumber}; - my $item = Koha::Item->new( $new_item ); + my $item = Koha::Item->new( $new_item )->store; my $itemnumber = $item->itemnumber; $logger->trace("New item $itemnumber added"); $schema->resultset('AqordersItem')->create( -- 2.26.2