Bugzilla – Attachment 10757 Details for
Bug 8130
attach PDF files to a patron record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8130 [FOLLOW-UP] attach PDF files to a patron record
Bug-8130-FOLLOW-UP-attach-PDF-files-to-a-patron-re.patch (text/plain), 5.20 KB, created by
Owen Leonard
on 2012-07-10 18:09:02 UTC
(
hide
)
Description:
Bug 8130 [FOLLOW-UP] attach PDF files to a patron record
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-07-10 18:09:02 UTC
Size:
5.20 KB
patch
obsolete
>From 371c3205bd0ac3f80028838889504d0b5a6b9ab0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 10 Jul 2012 13:56:26 -0400 >Subject: [PATCH] Bug 8130 [FOLLOW-UP] attach PDF files to a patron record >Content-Type: text/plain; charset="utf-8" > >Markup corrections: > >- Hide table of files if no files are attached >- Move error messages out of table (invalid) >- Add <tr> tags to table (invalid) >- Apply standard form structure to upload form >- Add proper labels and ids to upload form >- Correct unescaped ampersands >--- > .../intranet-tmpl/prog/en/modules/members/files.tt | 52 +++++++++++--------- > 1 file changed, 30 insertions(+), 22 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt >index 1655823..a44aaa9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt >@@ -17,49 +17,58 @@ > > <h1>Files</h1> > >+ [% IF errors %] >+ <div class="dialog alert"> >+ [% IF errors.empty_upload %]The file you are attempting to upload has no contents.[% END %] >+ [% IF errors.no_file %]You did not select a file to upload.[% END %] >+ </div> >+ [% END %] >+ >+ [% IF ( files ) %] > <table> > <thead> >- <th>Name</th> >- <th>Type</th> >- <th>Description</th> >- <th>Uploaded</th> >- [% IF CAN_user_borrowers %]<th> </th>[% END %] >+ <tr> >+ <th>Name</th> >+ <th>Type</th> >+ <th>Description</th> >+ <th>Uploaded</th> >+ [% IF CAN_user_borrowers %]<th> </th>[% END %] >+ </tr> > </thead> > > <tbody> >- [% IF errors %] >- <div class="error warn"> >- [% IF errors.empty_upload %]The file you are attempting to upload has no contents.[% END %] >- [% IF errors.no_file %]You did not select a file to upload.[% END %] >- </div> >- [% END %] >- > [% FOREACH f IN files %] > <tr> >- <td><a href="?borrowernumber=[% borrowernumber %]&op=download&file_id=[% f.file_id %]">[% f.file_name %]</a></td> >+ <td><a href="?borrowernumber=[% borrowernumber %]&op=download&file_id=[% f.file_id %]">[% f.file_name %]</a></td> > <td>[% f.file_type %]</td> > <td>[% f.file_description %]</td> > <td>[% f.date_uploaded | $KohaDates %]</td> >- [% IF CAN_user_borrowers %]<td><a href="?borrowernumber=[% borrowernumber %]&op=delete&file_id=[% f.file_id %]">Delete</a></td>[% END %] >+ [% IF CAN_user_borrowers %]<td><a href="?borrowernumber=[% borrowernumber %]&op=delete&file_id=[% f.file_id %]">Delete</a></td>[% END %] > </tr> > [% END %] > </tbody> > </table> >+ [% ELSE %] >+ <div class="dialog message"> >+ <p>This patron has no files attached.</p> >+ </div> >+ [% END %] > >- <form method="post" enctype="multipart/form-data"> >- <fieldset> >+ <form method="post" action="/cgi-bin/koha/members/files.pl" enctype="multipart/form-data"> >+ <fieldset class="rows"> > <legend>Upload New File</legend> >- >- <input type="hidden" name="op" value="upload" /> >+ <ol> >+ <li><input type="hidden" name="op" value="upload" /> > <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" /> > <input type="hidden" name="MAX_FILE_SIZE" value="2000000" /> > > <label for="description">Description:</label> >- <input name="description" type="text" /> >+ <input name="description" id="description" type="text" /></li> > >- <input name="uploadfile" type="file" id="uploadfile" /> >+ <li><label for="uploadfile">File:</label><input name="uploadfile" type="file" id="uploadfile" /></li> > >- <input name="upload" type="submit" id="upload" value="Upload File" /> >+ </ol> >+ <fieldset class="action"><input name="upload" type="submit" id="upload" value="Upload File" /></fieldset> > </fieldset> > </form> > >@@ -70,5 +79,4 @@ > [% INCLUDE 'circ-menu.inc' %] > </div> > </div> >-</div> > [% INCLUDE 'intranet-bottom.inc' %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8130
:
9684
|
9685
|
9858
|
10147
|
10173
|
10176
|
10177
|
10185
|
10312
|
10419
|
10757
|
11001
|
11003
|
11006
|
11007
|
11008
|
11009
|
11010