From e297466068bf1229dcf589ed80f9609ec7a5b752 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 31 Jul 2020 11:14:20 -0300 Subject: [PATCH] Bug 26114: ILL should mark status=RET only if a return happened The original code assumed every codepath should be trated as a successful check-in. Such is not the case and the regression tests verify that the code acknowledges this. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Illrequests.t => FAIL: Tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index a9cf02ca3d..bab02a62ef 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2169,7 +2169,7 @@ sub AddReturn { # Check if this item belongs to a biblio record that is attached to an # ILL request, if it is we need to update the ILL request's status - if (C4::Context->preference('CirculateILL')) { + if ( $doreturn and C4::Context->preference('CirculateILL')) { my $request = Koha::Illrequests->find( { biblio_id => $item->biblio->biblionumber } ); -- 2.28.0