@@ -, +, @@ --- Koha/Patrons.pm | 2 +- misc/cronjobs/update_patrons_category.pl | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) --- a/Koha/Patrons.pm +++ a/Koha/Patrons.pm @@ -397,7 +397,7 @@ sub search_patrons_to_update_category { } if ($params->{fine_min} || $params->{fine_max}) { $query{join} = ["accountlines"]; - $query{select} = ["borrowernumber", "accountlines.amountoutstanding" ]; + $query{columns} = ["borrowernumber"]; $query{group_by} = ["borrowernumber"]; $query{having} = \['IFNULL(sum(accountlines.amountoutstanding),0) <= ?',$params->{fine_max}] if defined $params->{fine_max}; $query{having} = \['IFNULL(sum(accountlines.amountoutstanding),0) >= ?',$params->{fine_min}] if defined $params->{fine_min}; --- a/misc/cronjobs/update_patrons_category.pl +++ a/misc/cronjobs/update_patrons_category.pl @@ -74,7 +74,7 @@ Print a brief help message and exits. Prints the manual page and exits. -=item B<--verbosse | -v> +=item B<--verbose | -v> Verbose. Without this flag set, only fatal errors are reported. @@ -248,17 +248,18 @@ my $target_patrons = Koha::Patrons->search(\%params)->search_patrons_to_update_c fine_max => $fine_max, } ); + my $patrons_found = $target_patrons->count; my $actually_updated = 0; my $testdisplay = $doit ? "" : "WOULD HAVE "; if ($verbose) { while ( my $target_patron = $target_patrons->next() ) { - my $target = Koha::Patrons->find( $target_patron->borrowernumber ); + $target_patron->discard_changes(); $verbose and print $testdisplay . "Updated " - . $target->firstname . " " - . $target->surname + . $target_patron->firstname() . " " + . $target_patron->surname() . " from $fromcat to $tocat\n"; } $target_patrons->reset; --