From 5bb845df3f78b25e8d37f96624a3338cf284d3e5 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 5 Aug 2020 17:27:58 +0000
Subject: [PATCH] Bug 26151: Remove the use of jquery.checkboxes plugin from
 suggestions management page

This patch removes the use of the jquery.checkboxes plugin from the
suggestions management page and replaces it with custom JS.

To test, apply the patch and go to Acquisitions -> Suggestions

Under each tab ("Accepted," "Pending," etc.), test that the "Check all"
and "Uncheck all" controls work correctly and only affect the table on
that tab.
---
 .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt   | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index c293a57ba3..0821d4459c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -998,8 +998,6 @@
     [% IF op == 'else' %]
         [% INCLUDE 'datatables.inc' %]
         [% INCLUDE 'columns_settings.inc' %]
-        [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
-
         <script>
             $(document).ready(function() {
                 $('#suggestiontabs').tabs();
@@ -1020,13 +1018,15 @@
 
                 $(".checkall").click(function(e){
                     e.preventDefault();
-                    $(this).parents('form').checkCheckboxes();
-                    return false;
+                    $(this).parents('form').find("input:checkbox").each(function(){
+                        $(this).prop("checked", true);
+                    });
                 });
                 $(".uncheckall").click(function(e){
                     e.preventDefault();
-                    $(this).parents('form').unCheckCheckboxes();
-                    return false;
+                    $(this).parents('form').find("input:checkbox").each(function(){
+                        $(this).prop("checked", false);
+                    });
                 });
                 $(".other_reason").hide();
                 $("select[name='reason']").change(function(){
-- 
2.11.0