Bugzilla – Attachment 107917 Details for
Bug 26009
Elasticsearch homebranch and holdingbranch facets are limited to 10
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26009: (QA follow-up) It does not harm to test more
Bug-26009-QA-follow-up-It-does-not-harm-to-test-mo.patch (text/plain), 1.85 KB, created by
Josef Moravec
on 2020-08-06 19:17:26 UTC
(
hide
)
Description:
Bug 26009: (QA follow-up) It does not harm to test more
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2020-08-06 19:17:26 UTC
Size:
1.85 KB
patch
obsolete
>From fe483109c07c4def2e3c7155a9d80a5e7b85c5d6 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Thu, 6 Aug 2020 19:15:44 +0000 >Subject: [PATCH] Bug 26009: (QA follow-up) It does not harm to test more > >Test plan: >prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >--> should return green > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >index ee8b81a4a7..a9d886e7bf 100644 >--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t >@@ -216,7 +216,7 @@ subtest 'build_authorities_query_compat() tests' => sub { > }; > > subtest 'build_query tests' => sub { >- plan tests => 51; >+ plan tests => 52; > > my $qb; > >@@ -248,7 +248,8 @@ subtest 'build_query tests' => sub { > $query = $qb->build_query('test', %options); > ok( defined $query->{aggregations}{ccode}{terms}{size},'we need to ask for a size or we get only 5 facet' ); > is( $query->{aggregations}{ccode}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount'); >- is( $query->{aggregations}{homebranch}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount fir homebranch'); >+ is( $query->{aggregations}{homebranch}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount for homebranch'); >+ is( $query->{aggregations}{holdingbranch}{terms}{size}, 37,'we ask for the size as defined by the syspref FacetMaxCount for holdingbranch'); > > t::lib::Mocks::mock_preference('DisplayLibraryFacets','both'); > $query = $qb->build_query(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26009
:
107044
|
107717
|
107916
| 107917