Bugzilla – Attachment 108082 Details for
Bug 25348
Add support for circulation status 12 ( lost )
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25348: (QA follow-up) Silence irrelevant warnings
Bug-25348-QA-follow-up-Silence-irrelevant-warnings.patch (text/plain), 2.14 KB, created by
Tomás Cohen Arazi
on 2020-08-11 15:42:26 UTC
(
hide
)
Description:
Bug 25348: (QA follow-up) Silence irrelevant warnings
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2020-08-11 15:42:26 UTC
Size:
2.14 KB
patch
obsolete
>From b528a2461c29779e9abfda7024d458356f381f90 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 11 Aug 2020 12:41:57 -0300 >Subject: [PATCH] Bug 25348: (QA follow-up) Silence irrelevant warnings > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/SIP/Transaction.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index a11b6b48db..c4c164adb1 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -352,11 +352,11 @@ subtest checkin_lost => sub { > my $ils = C4::SIP::ILS->new( $instituation ); > > t::lib::Mocks::mock_preference('BlockReturnOfLostItems', '1'); >- my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp ); >+ my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); > is( $circ->{screen_msg}, 'Item lost, return not allowed', "Got correct screen message" ); > > t::lib::Mocks::mock_preference('BlockReturnOfLostItems', '0'); >- $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp ); >+ $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); > is( $circ->{screen_msg}, 'Item not checked out', "Got 'Item not checked out' screen message" ); > }; > >@@ -390,11 +390,11 @@ subtest checkin_withdrawn => sub { > my $ils = C4::SIP::ILS->new( $instituation ); > > t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems', '1'); >- my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp ); >+ my $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); > is( $circ->{screen_msg}, 'Item withdrawn, return not allowed', "Got correct screen message" ); > > t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems', '0'); >- $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp ); >+ $circ = $ils->checkin( $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode ); > is( $circ->{screen_msg}, 'Item not checked out', "Got 'Item not checked out' screen message" ); > }; > >-- >2.28.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25348
:
104125
|
104174
|
108077
|
108081
| 108082