From 0eacdc6a3ffe825699f9ea4d993b569f9cf571c7 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 12 Aug 2020 14:44:52 -0300 Subject: [PATCH] Bug 26132: (QA follow-up) Make tests more robust Tests fail is SearchEngine is set to Elasticsearch. This patch makes tests build 'real' biblios. Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Koha/ItemTypes.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Koha/ItemTypes.t b/t/db_dependent/Koha/ItemTypes.t index 7f5e9e8188..22a8bd65a1 100755 --- a/t/db_dependent/Koha/ItemTypes.t +++ b/t/db_dependent/Koha/ItemTypes.t @@ -124,13 +124,13 @@ my $item_type = $builder->build_object({ class => 'Koha::ItemTypes' }); is( $item_type->can_be_deleted, 1, 'An item type that is not used can be deleted'); -my $item = $builder->build_object({ class => 'Koha::Items', value => { itype => $item_type->itemtype }}); +my $item = $builder->build_sample_item({ itype => $item_type->itemtype }); is( $item_type->can_be_deleted, 0, 'An item type that is used by an item cannot be deleted' ); $item->delete; -my $biblioitem = $builder->build_object({ class => 'Koha::Biblioitems', value => { itemtype => $item_type->itemtype }}); +my $biblio = $builder->build_sample_biblio({ itemtype => $item_type->itemtype }); is ( $item_type->can_be_deleted, 0, 'An item type that is used by an item and a biblioitem cannot be deleted' ); -$biblioitem->delete; +$biblio->delete; is ( $item_type->can_be_deleted, 1, 'The item type that was being used by the removed item and biblioitem can now be deleted' ); -- 2.28.0