From a3fbb188d09d2d5d2341d8b37af5d4b1cff3186a Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 14 Aug 2020 13:39:17 +0000 Subject: [PATCH] Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer --- .../prog/en/modules/offline_circ/list.tt | 30 ++++++++++++---------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt index 451b8f223d..65d1ff4c87 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt @@ -21,8 +21,11 @@ [% IF ( pending_operations ) %]
-

| -

+

+ Check all + Uncheck all +

+ @@ -37,8 +40,10 @@ [% FOREACH operation IN pending_operations %] - - + +
[% operation.timestamp | html %] + + [% SWITCH ( operation.action ) -%] [% CASE "issue" -%] @@ -89,19 +94,16 @@ [% MACRO jsinclude BLOCK %] - [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] -