From 655ca63b7e78be9771e18a4615af1f6406c416d0 Mon Sep 17 00:00:00 2001 From: Didier Gautheron Date: Tue, 18 Aug 2020 07:40:50 +0200 Subject: [PATCH] Bug 26232: Empty smart rule fine grace period Staff can create smart rules with empty (undefined) fine grace period. In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm. To test prove t/db_dependent/Circulation.t --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index f530d92a72..b868e7b8bd 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2392,7 +2392,7 @@ sub _calculate_new_debar_dt { # grace period is measured in the same units as the loan my $grace = - DateTime::Duration->new( $unit => $issuing_rule->{firstremind} ); + DateTime::Duration->new( $unit => $issuing_rule->{firstremind} // 0); my $deltadays = DateTime::Duration->new( days => $chargeable_units -- 2.11.0