Bugzilla – Attachment 108584 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: (QA follow-up) Remove FIXME + Track issue_id
Bug-18501-QA-follow-up-Remove-FIXME--Track-issueid.patch (text/plain), 1.77 KB, created by
Martin Renvoize
on 2020-08-19 10:42:03 UTC
(
hide
)
Description:
Bug 18501: (QA follow-up) Remove FIXME + Track issue_id
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-08-19 10:42:03 UTC
Size:
1.77 KB
patch
obsolete
>From b9a2beaa02457651977016b5bb43e42af9156a5c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 14 Aug 2020 11:53:59 +0100 >Subject: [PATCH] Bug 18501: (QA follow-up) Remove FIXME + Track issue_id > >We correct some compilation errors here by updating the transfered >_FixAccountForLostAndFound method to use $self references. We add >issue_id tracking so that future reports can clearly see how a refund >relates to the original charge and finally we remove a FIXME as I agree >that the 'discard_changes' call is not required. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Item.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index f2ca45d81b..ff6a4d5690 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -864,11 +864,12 @@ sub _set_found_trigger { > $credit = $account->add_credit( > { > amount => $credit_total, >- description => 'Item found ' . $item_id, >+ description => 'Item found ' . $self->itemnumber, > type => 'LOST_FOUND', > interface => C4::Context->interface, > library_id => $branchcode, >- item_id => $itemnumber >+ item_id => $self->itemnumber, >+ issue_id => $accountline->issue_id > } > ); > >@@ -877,8 +878,7 @@ sub _set_found_trigger { > } > > # Update the account status >- $accountline->discard_changes->status('FOUND') >- ; # FIXME JD Why discard_changes? $accountline has not been modified since last fetch >+ $accountline->status('FOUND'); > $accountline->store; > > if ( defined $account and C4::Context->preference('AccountAutoReconcile') ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295