From 31914ae5ba8ddf98f5f1e54c99674f694884e1d8 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Wed, 19 Aug 2020 12:21:27 +0000
Subject: [PATCH] Bug 19889: (QA follow-up) use em over i and update field if
unset
em is better for accessibility
We should set the field to 0 when it was previously unset
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 6 +++---
tools/batchMod.pl | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
index ea1a2d5f9d..5cde5134a7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ -60,11 +60,11 @@
[% IF updated_exclude_from_local_holds_priority.defined %]
<div class="dialog message">
- <i>Exclude from local holds priority</i> updated to
+ <em>Exclude from local holds priority</em> updated to
[% IF updated_exclude_from_local_holds_priority %]
- <i>Yes</i>
+ <em>Yes</em>
[% ELSE %]
- <i>No</i>
+ <em>No</em>
[% END %]
</div>
[% END %]
diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 719848f418..7299fc9d93 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -242,7 +242,7 @@ if ($op eq "action") {
else {
my $modified_holds_priority = 0;
if (defined $exclude_from_local_holds_priority) {
- if($item->exclude_from_local_holds_priority != $exclude_from_local_holds_priority) {
+ if(!defined $item->exclude_from_local_holds_priority || $item->exclude_from_local_holds_priority != $exclude_from_local_holds_priority) {
$item->exclude_from_local_holds_priority($exclude_from_local_holds_priority)->store;
$modified_holds_priority = 1;
}
--
2.11.0