Bugzilla – Attachment 108615 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: but.. what was the meaning of holdingbranch here?
Bug-18501-but-what-was-the-meaning-of-holdingbranc.patch (text/plain), 1.34 KB, created by
Jonathan Druart
on 2020-08-19 12:42:26 UTC
(
hide
)
Description:
Bug 18501: but.. what was the meaning of holdingbranch here?
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-19 12:42:26 UTC
Size:
1.34 KB
patch
obsolete
>From 17df41d8db093577d9b380b44de1e62ca85164f9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 13 Aug 2020 18:42:56 +0200 >Subject: [PATCH] Bug 18501: but.. what was the meaning of holdingbranch here? > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Circulation.pm | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index bb235b9df6..dfdbb1a5fa 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2008,7 +2008,6 @@ sub AddReturn { > > # the holdingbranch is updated if the document is returned to another location. > # this is always done regardless of whether the item was on loan or not >- my $item_holding_branch = $item->holdingbranch; > if ($item->holdingbranch ne $branch) { > $item->holdingbranch($branch)->store; > } >@@ -2040,12 +2039,6 @@ sub AddReturn { > if ( $item->itemlost ) { > $messages->{'WasLost'} = 1; > unless ( C4::Context->preference("BlockReturnOfLostItems") ) { >- my $refunded = $item->set_found( >- { >- holdingbranch => $item_holding_branch, >- } >- ); >- > $messages->{'LostItemFeeRefunded'} = $refunded; > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
| 108615 |
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295