From 467092a2c8a1a2a3b6f8ece766acdb72802fb3f3 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 10 Aug 2020 12:57:45 -0300
Subject: [PATCH] Bug 22343: Prevent passing password to the UI

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 admin/smtp_servers.pl                                         | 3 +++
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/admin/smtp_servers.pl b/admin/smtp_servers.pl
index 8733f3fa07..becdfb9d66 100755
--- a/admin/smtp_servers.pl
+++ b/admin/smtp_servers.pl
@@ -165,6 +165,9 @@ elsif ( $op eq 'edit_save' ) {
         my $password   = $input->param('smtp_password') || undef;
         my $debug      = ( scalar $input->param('smtp_debug_mode') ) ? 1 : 0;
 
+        $password = undef
+            if defined $password and $password eq '****';
+
         try {
             $smtp_server->password( $password )
                 if $password;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
index cac27fa5be..5a53431da9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
@@ -193,7 +193,7 @@
                 </li>
                 <li>
                     <label for="smtp_password">Password: </label>
-                    <input type="password" name="smtp_password" id="smtp_password" size="60"  value="[%- smtp_server.password | html -%]"/>
+                    <input type="password" name="smtp_password" id="smtp_password" size="60"  value="****"/>
                 </li>
                 <li>
                     <label for="smtp_debug_mode">Debug mode: </label>
-- 
2.24.1 (Apple Git-126)