Bugzilla – Attachment 108717 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: Fix QA issues
Bug-18501-Fix-QA-issues.patch (text/plain), 2.24 KB, created by
Jonathan Druart
on 2020-08-20 09:49:46 UTC
(
hide
)
Description:
Bug 18501: Fix QA issues
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-20 09:49:46 UTC
Size:
2.24 KB
patch
obsolete
>From 710abbfd0efbc4fd4b23751e57030e7b62b9a458 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 20 Aug 2020 11:49:08 +0200 >Subject: [PATCH] Bug 18501: Fix QA issues > > FAIL Koha/Item.pm > FAIL critic > # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). > FAIL spelling > Retreive ==> Retrieve > appropriatly ==> appropriately > somehwere ==> somewhere >--- > Koha/Item.pm | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 78c23dbab0..84ba2da33c 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -124,11 +124,12 @@ sub store { > my %updated_columns = $self->_result->get_dirty_columns; > return $self->SUPER::store unless %updated_columns; > >- # Retreive the item for comparison if we need to >- my $pre_mod_item = $self->get_from_storage >- if ( exists $updated_columns{itemlost} >- or exists $updated_columns{withdrawn} >- or exists $updated_columns{damaged} ); >+ # Retrieve the item for comparison if we need to >+ my $pre_mod_item = ( >+ exists $updated_columns{itemlost} >+ or exists $updated_columns{withdrawn} >+ or exists $updated_columns{damaged} >+ ) ? $self->get_from_storage : undef; > > # Update *_on fields if needed > # FIXME: Why not for AddItem as well? >@@ -785,7 +786,7 @@ sub renewal_branchcode { > $self->_set_found_trigger > > Finds the most recent lost item charge for this item and refunds the patron >-appropriatly, taking into account any payments or writeoffs already applied >+appropriately, taking into account any payments or writeoffs already applied > against the charge. > > Internal function, not exported, called only by Koha::Item->store. >@@ -837,7 +838,7 @@ sub _set_found_trigger { > my $patron = Koha::Patrons->find( $accountline->borrowernumber ); > return $self > unless $patron; # Patron has been deleted, nobody to credit the return to >- # FIXME Should not we notify this somehwere >+ # FIXME Should not we notify this somewhere > > my $account = $patron->account; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
| 108717 |
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295