Bugzilla – Attachment 108738 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: (follow-up) Remove duplicate test
Bug-18501-follow-up-Remove-duplicate-test.patch (text/plain), 1.94 KB, created by
Martin Renvoize
on 2020-08-20 14:33:39 UTC
(
hide
)
Description:
Bug 18501: (follow-up) Remove duplicate test
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-08-20 14:33:39 UTC
Size:
1.94 KB
patch
obsolete
>From 3494a7248cc13ada8e84d3040ef3ec15e3d50cd3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 20 Aug 2020 12:38:23 +0100 >Subject: [PATCH] Bug 18501: (follow-up) Remove duplicate test > >The ModItem test found in t/db_dependent/Items.t was a duplciate (but >slightly less functional) for the test we introduced for the *_on >trigger functionality in t/db_dependent/Koha/Items.t::store > >The failure was a missing C4::Context mock, but the logical fix is to >simply remove the duplicate test. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Items.t | 27 +-------------------------- > 1 file changed, 1 insertion(+), 26 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 010b41e97a..3da406ac9e 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -33,7 +33,7 @@ use Koha::AuthorisedValues; > use t::lib::Mocks; > use t::lib::TestBuilder; > >-use Test::More tests => 15; >+use Test::More tests => 14; > > use Test::Warn; > >@@ -126,31 +126,6 @@ subtest 'General Add, Get and Del tests' => sub { > $schema->storage->txn_rollback; > }; > >-subtest 'ModItem tests' => sub { >- plan tests => 6; >- >- $schema->storage->txn_begin; >- >- my $builder = t::lib::TestBuilder->new; >- my $item = $builder->build_sample_item(); >- >- my @fields = qw( itemlost withdrawn damaged ); >- for my $field (@fields) { >- my $field_on = $field."_on"; >- >- $item->$field(1)->store; >- $item->discard_changes; >- is( output_pref({ str => $item->$field_on, dateonly => 1 }), output_pref({ dt => dt_from_string(), dateonly => 1 }), "When updating $field, $field_on is updated" ); >- >- $item->$field(0)->store; >- $item->discard_changes; >- is( $item->$field_on, undef, "When clearing $field, $field_on is cleared" ); >- } >- >- $schema->storage->txn_rollback; >- >-}; >- > subtest 'ModItemTransfer tests' => sub { > plan tests => 8; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
|
108788
|
108795
|
111295