View | Details | Raw Unified | Return to bug 22690
Collapse All | Expand All

(-)a/C4/Items.pm (-37 / +16 lines)
Lines 66-71 use Koha::AuthorisedValues; Link Here
66
use Koha::DateUtils qw(dt_from_string);
66
use Koha::DateUtils qw(dt_from_string);
67
use Koha::Database;
67
use Koha::Database;
68
68
69
use Koha::Biblios;
69
use Koha::Biblioitems;
70
use Koha::Biblioitems;
70
use Koha::Items;
71
use Koha::Items;
71
use Koha::ItemTypes;
72
use Koha::ItemTypes;
Lines 1070-1076 the inner workings of C<C4::Items>. Link Here
1070
1071
1071
=head2 MoveItemFromBiblio
1072
=head2 MoveItemFromBiblio
1072
1073
1073
  MoveItemFromBiblio($itenumber, $frombiblio, $tobiblio);
1074
  MoveItemFromBiblio($itemnumber, $frombiblio, $tobiblio);
1074
1075
1075
Moves an item from a biblio to another
1076
Moves an item from a biblio to another
1076
1077
Lines 1080-1121 Returns undef if the move failed or the biblionumber of the destination record o Link Here
1080
1081
1081
sub MoveItemFromBiblio {
1082
sub MoveItemFromBiblio {
1082
    my ($itemnumber, $frombiblio, $tobiblio) = @_;
1083
    my ($itemnumber, $frombiblio, $tobiblio) = @_;
1083
    my $dbh = C4::Context->dbh;
1084
1084
    my ( $tobiblioitem ) = $dbh->selectrow_array(q|
1085
    my $item = Koha::Items->find($itemnumber);
1085
        SELECT biblioitemnumber
1086
    return unless $item;
1086
        FROM biblioitems
1087
1087
        WHERE biblionumber = ?
1088
    my $biblio = Koha::Biblios->find($tobiblio);
1088
    |, undef, $tobiblio );
1089
    return unless $biblio;
1089
    my $return = $dbh->do(q|
1090
1090
        UPDATE items
1091
    return unless $item->biblionumber != $biblio->biblionumber;
1091
        SET biblioitemnumber = ?,
1092
1092
            biblionumber = ?
1093
    $item->move_to_biblio($biblio);
1093
        WHERE itemnumber = ?
1094
    ModZebra($tobiblio, 'specialUpdate', 'biblioserver');
1094
            AND biblionumber = ?
1095
    ModZebra($frombiblio, 'specialUpdate', 'biblioserver');
1095
    |, undef, $tobiblioitem, $tobiblio, $itemnumber, $frombiblio );
1096
1096
    if ($return == 1) {
1097
    return $tobiblio;
1097
        ModZebra( $tobiblio, "specialUpdate", "biblioserver" );
1098
        ModZebra( $frombiblio, "specialUpdate", "biblioserver" );
1099
	    # Checking if the item we want to move is in an order 
1100
        require C4::Acquisition;
1101
        my $order = C4::Acquisition::GetOrderFromItemnumber($itemnumber);
1102
	    if ($order) {
1103
		    # Replacing the biblionumber within the order if necessary
1104
		    $order->{'biblionumber'} = $tobiblio;
1105
	        C4::Acquisition::ModOrder($order);
1106
	    }
1107
1108
        # Update reserves, hold_fill_targets, tmp_holdsqueue and linktracker tables
1109
        for my $table_name ( qw( reserves hold_fill_targets tmp_holdsqueue linktracker ) ) {
1110
            $dbh->do( qq|
1111
                UPDATE $table_name
1112
                SET biblionumber = ?
1113
                WHERE itemnumber = ?
1114
            |, undef, $tobiblio, $itemnumber );
1115
        }
1116
        return $tobiblio;
1117
	}
1118
    return;
1119
}
1098
}
1120
1099
1121
=head2 _marc_from_item_hash
1100
=head2 _marc_from_item_hash
(-)a/Koha/Biblio.pm (+22 lines)
Lines 816-821 sub to_api_mapping { Link Here
816
    };
816
    };
817
}
817
}
818
818
819
=head3 adopt_items_from_biblio
820
821
$biblio->adopt_items_from_biblio($from_biblio);
822
823
Move items from the given biblio to this one.
824
825
=cut
826
827
sub adopt_items_from_biblio {
828
    my ( $self, $from_biblio ) = @_;
829
830
    my $items = $from_biblio->items;
831
    if ($items) {
832
        while (my $item = $items->next()) {
833
            $item->move_to_biblio($self);
834
        }
835
        C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" );
836
        C4::Biblio::ModZebra( $from_biblio->biblionumber, "specialUpdate", "biblioserver" );
837
    }
838
}
839
840
819
=head2 Internal methods
841
=head2 Internal methods
820
842
821
=head3 type
843
=head3 type
(-)a/Koha/Item.pm (+63 lines)
Lines 965-970 sub itemtype { Link Here
965
    return Koha::ItemTypes->find( $self->effective_itemtype );
965
    return Koha::ItemTypes->find( $self->effective_itemtype );
966
}
966
}
967
967
968
=head3 item_orders
969
970
my $orders = $item->item_orders();
971
972
Returns a Koha::Acquisition::Orders object
973
974
=cut
975
976
sub item_orders {
977
    my ( $self ) = @_;
978
979
    my $orders = $self->_result->item_orders;
980
    return Koha::Acquisition::Orders->_new_from_dbic($orders);
981
}
982
983
=head3 move_to_biblio
984
985
  $item->move_to_biblio($to_biblio);
986
987
Move the item to another biblio and update any references also in other tables.
988
989
=cut
990
991
sub move_to_biblio {
992
    my ( $self, $to_biblio ) = @_;
993
994
    my $biblionumber = $to_biblio->biblionumber;
995
996
    # Own biblionumber and biblioitemnumber
997
    $self->set({
998
        biblionumber => $biblionumber,
999
        biblioitemnumber => $to_biblio->biblioitem->biblioitemnumber
1000
    })->store({ skip_modzebra_update => 1 });
1001
1002
    # Acquisition orders
1003
    $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
1004
1005
    # Holds
1006
    $self->holds->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
1007
1008
    # hold_fill_target (there's no Koha object available)
1009
    my $hold_fill_target = $self->_result->hold_fill_target;
1010
    if ($hold_fill_target) {
1011
        $hold_fill_target->update({ biblionumber => $biblionumber });
1012
    }
1013
1014
    # tmp_holdsqueues - Can't update with DBIx since the table is missing a primary key
1015
    # and can't even fake one since the significant columns are nullable.
1016
    my $storage = $self->_result->result_source->storage;
1017
    $storage->dbh_do(
1018
        sub {
1019
            my ($storage, $dbh, @cols) = @_;
1020
1021
            $dbh->do("UPDATE tmp_holdsqueue SET biblionumber=? WHERE itemnumber=?", undef, $biblionumber, $self->itemnumber);
1022
        }
1023
    );
1024
1025
    # linktrackers
1026
    my $schema = Koha::Database->new()->schema();
1027
    my $linktrackers = $schema->resultset('Linktracker')->search({ itemnumber => $self->itemnumber });
1028
    $linktrackers->update_all({ biblionumber => $biblionumber });
1029
}
1030
968
=head2 Internal methods
1031
=head2 Internal methods
969
1032
970
=head3 _after_item_action_hooks
1033
=head3 _after_item_action_hooks
(-)a/Koha/Schema/Result/Item.pm (+13 lines)
Lines 759-764 __PACKAGE__->belongs_to( Link Here
759
  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
759
  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
760
);
760
);
761
761
762
# Relationship with orders via the aqorders_item table that not have foreign keys
763
__PACKAGE__->has_many(
764
  "aqorders_item",
765
  "Koha::Schema::Result::AqordersItem",
766
  { "foreign.itemnumber" => "self.itemnumber" },
767
  { cascade_copy => 0, cascade_delete => 0 },
768
);
769
__PACKAGE__->many_to_many(
770
  "item_orders",
771
  "aqorders_item",
772
  "ordernumber",
773
);
774
762
use C4::Context;
775
use C4::Context;
763
sub effective_itemtype {
776
sub effective_itemtype {
764
    my ( $self ) = @_;
777
    my ( $self ) = @_;
(-)a/cataloguing/merge.pl (-15 / +7 lines)
Lines 31-36 use C4::Reserves qw/MergeHolds/; Link Here
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
32
32
33
use Koha::BiblioFrameworks;
33
use Koha::BiblioFrameworks;
34
use Koha::Biblios;
34
use Koha::Items;
35
use Koha::Items;
35
use Koha::MetadataRecord;
36
use Koha::MetadataRecord;
36
37
Lines 81-105 if ($merge) { Link Here
81
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
82
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
82
83
83
    my $frameworkcode = $input->param('frameworkcode');
84
    my $frameworkcode = $input->param('frameworkcode');
84
    my @notmoveditems;
85
85
86
    # Modifying the reference record
86
    # Modifying the reference record
87
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
87
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
88
88
89
    # Moving items from the other record to the reference record
89
    # Moving items and article requests from the other record to the reference record
90
    my $biblio = Koha::Biblios->find($ref_biblionumber);
90
    foreach my $biblionumber (@biblionumbers) {
91
    foreach my $biblionumber (@biblionumbers) {
91
        my $items = Koha::Items->search({ biblionumber => $biblionumber });
92
        my $from_biblio = Koha::Biblios->find($biblionumber);
92
        while ( my $item = $items->next) {
93
        $biblio->adopt_items_from_biblio($from_biblio);
93
            my $res = MoveItemFromBiblio( $item->itemnumber, $biblionumber, $ref_biblionumber );
94
        $from_biblio->article_requests->update({ biblionumber => $ref_biblionumber }, { no_triggers => 1 });
94
            if ( not defined $res ) {
95
                push @notmoveditems, $item->itemnumber;
96
            }
97
        }
98
    }
99
    # If some items could not be moved :
100
    if (scalar(@notmoveditems) > 0) {
101
        my $itemlist = join(' ',@notmoveditems);
102
        push @errors, { code => "CANNOT_MOVE", value => $itemlist };
103
    }
95
    }
104
96
105
    my $sth_subscription = $dbh->prepare("
97
    my $sth_subscription = $dbh->prepare("
Lines 163-169 if ($merge) { Link Here
163
    # Moving suggestions
155
    # Moving suggestions
164
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
156
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
165
157
166
    # Moving orders (orders linked to items of frombiblio have already been moved by MoveItemFromBiblio)
158
    # Moving orders (orders linked to items of frombiblio have already been moved by adopt_items_from_biblio)
167
    my @allorders = GetOrdersByBiblionumber($biblionumber);
159
    my @allorders = GetOrdersByBiblionumber($biblionumber);
168
    foreach my $myorder (@allorders) {
160
    foreach my $myorder (@allorders) {
169
        $myorder->{'biblionumber'} = $ref_biblionumber;
161
        $myorder->{'biblionumber'} = $ref_biblionumber;
(-)a/t/db_dependent/Items/MoveItemFromBiblio.t (+3 lines)
Lines 25-36 use Koha::Holds; Link Here
25
use Koha::Items;
25
use Koha::Items;
26
26
27
use t::lib::TestBuilder;
27
use t::lib::TestBuilder;
28
use t::lib::Mocks;
28
use Data::Dumper qw|Dumper|;
29
use Data::Dumper qw|Dumper|;
29
30
30
my $schema  = Koha::Database->new->schema;
31
my $schema  = Koha::Database->new->schema;
31
$schema->storage->txn_begin;
32
$schema->storage->txn_begin;
32
my $builder = t::lib::TestBuilder->new;
33
my $builder = t::lib::TestBuilder->new;
33
34
35
t::lib::Mocks::mock_preference( 'SearchEngine', 'Zebra' );
36
34
# NOTE This is a trick, if we want to populate the biblioitems table, we should not create a Biblio but a Biblioitem
37
# NOTE This is a trick, if we want to populate the biblioitems table, we should not create a Biblio but a Biblioitem
35
my $param = { source => 'Biblioitem' };
38
my $param = { source => 'Biblioitem' };
36
my $from_biblio = {
39
my $from_biblio = {
(-)a/t/db_dependent/Koha/Item.t (-3 / +106 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 7;
22
use Test::More tests => 8;
23
23
24
use C4::Biblio;
24
use C4::Biblio;
25
use C4::Circulation;
25
use C4::Circulation;
Lines 163-170 subtest 'pickup_locations' => sub { Link Here
163
    my $dbh = C4::Context->dbh;
163
    my $dbh = C4::Context->dbh;
164
164
165
    # Cleanup database
165
    # Cleanup database
166
    Koha::Holds->search->delete;
167
    $dbh->do('DELETE FROM issues');
166
    $dbh->do('DELETE FROM issues');
167
    Koha::Holds->search->delete;
168
    Koha::Patrons->search->delete;
168
    Koha::Patrons->search->delete;
169
    Koha::Items->search->delete;
169
    Koha::Items->search->delete;
170
    Koha::Libraries->search->delete;
170
    Koha::Libraries->search->delete;
Lines 518-520 subtest 'Tests for itemtype' => sub { Link Here
518
518
519
    $schema->storage->txn_rollback;
519
    $schema->storage->txn_rollback;
520
};
520
};
521
- 
521
522
subtest 'move_to_biblio() tests' => sub {
523
524
    plan tests => 12;
525
526
    $schema->storage->txn_begin;
527
528
    my $dbh = C4::Context->dbh;
529
530
    my $source_biblio = $builder->build_sample_biblio();
531
    my $target_biblio = $builder->build_sample_biblio();
532
533
    my $source_biblionumber = $source_biblio->biblionumber;
534
535
    my $item1 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
536
    my $item2 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
537
538
    my $itemnumber1 = $item1->itemnumber;
539
    my $itemnumber2 = $item2->itemnumber;
540
541
    my $library = $builder->build_object({ class => 'Koha::Libraries' });
542
543
    my $patron = $builder->build_object({
544
        class => 'Koha::Patrons',
545
        value => { branchcode => $library->branchcode, }
546
    });
547
    my $borrowernumber = $patron->borrowernumber;
548
549
    $dbh->do("INSERT INTO aqbudgets (budget_notes) VALUES ('test')");
550
    my $budget_id = $dbh->last_insert_id(undef, undef, 'aqbudgets', 'budget_id');
551
552
    $dbh->do('INSERT INTO aqorders (biblionumber, budget_id) VALUES (?, ?)', undef, $source_biblionumber, $budget_id);
553
    my $ordernumber1 = $dbh->last_insert_id(undef, undef, 'aqorders', 'ordernumber');
554
    $dbh->do('INSERT INTO aqorders_items (ordernumber, itemnumber) VALUES (?, ?)', undef, $ordernumber1, $itemnumber1);
555
556
    $dbh->do('INSERT INTO aqorders (biblionumber, budget_id) VALUES (?, ?)', undef, $source_biblionumber, $budget_id);
557
    my $ordernumber2 = $dbh->last_insert_id(undef, undef, 'aqorders', 'ordernumber');
558
    $dbh->do('INSERT INTO aqorders_items (ordernumber, itemnumber) VALUES (?, ?)', undef, $ordernumber2, $source_biblionumber);
559
560
    my $reserve_id1 = C4::Reserves::AddReserve({
561
        branch => $library->branchcode,
562
        borrowernumber => $borrowernumber,
563
        biblionumber => $source_biblionumber,
564
        itemnumber => $itemnumber1,
565
        title => 'title'
566
    });
567
568
    my $reserve_id2 = C4::Reserves::AddReserve({
569
        branch => $library->branchcode,
570
        borrowernumber => $patron->borrowernumber,
571
        biblionumber => $source_biblionumber,
572
        itemnumber => $itemnumber2,
573
        title => 'title'
574
    });
575
576
    $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber,biblionumber) VALUES ('Clamp',?,?,?)", undef, $borrowernumber, $itemnumber1, $source_biblionumber);
577
    $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber,biblionumber) VALUES ('Clamp',?,?,?)", undef, $borrowernumber, $itemnumber2, $source_biblionumber);
578
579
    $dbh->do('INSERT INTO hold_fill_targets (borrowernumber,itemnumber,biblionumber) VALUES (?,?,?)', undef, $borrowernumber, $itemnumber1, $source_biblionumber);
580
    $dbh->do('INSERT INTO hold_fill_targets (borrowernumber,itemnumber,biblionumber) VALUES (?,?,?)', undef, $borrowernumber, $itemnumber2, $source_biblionumber);
581
582
    $dbh->do('INSERT INTO linktracker (borrowernumber,itemnumber,biblionumber) VALUES (?,?,?)', undef, $borrowernumber, $itemnumber1, $source_biblionumber);
583
    $dbh->do('INSERT INTO linktracker (borrowernumber,itemnumber,biblionumber) VALUES (?,?,?)', undef, $borrowernumber, $itemnumber2, $source_biblionumber);
584
585
    $item1->move_to_biblio($target_biblio);
586
587
    my @result = $dbh->selectrow_array('SELECT biblionumber FROM items WHERE itemnumber = ?', undef, $itemnumber1);
588
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in the moved item');
589
590
    @result = $dbh->selectrow_array('SELECT biblionumber FROM items WHERE itemnumber = ?', undef, $itemnumber2);
591
    is($result[0], $source_biblionumber, 'Correct biblionumber in the unmoved item');
592
593
    @result = $dbh->selectrow_array('SELECT biblionumber FROM aqorders WHERE ordernumber = ?', undef, $ordernumber1);
594
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in aqorders for order with the moved item');
595
596
    @result = $dbh->selectrow_array('SELECT biblionumber FROM aqorders WHERE ordernumber = ?', undef, $ordernumber2);
597
    is($result[0], $source_biblionumber, 'Correct biblionumber in aqorders for order with the unmoved item');
598
599
    @result = $dbh->selectrow_array('SELECT biblionumber FROM reserves WHERE reserve_id = ?', undef, $reserve_id1);
600
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in reserves for moved item');
601
602
    @result = $dbh->selectrow_array('SELECT biblionumber FROM reserves WHERE reserve_id = ?', undef, $reserve_id2);
603
    is($result[0], $source_biblionumber, 'Correct biblionumber in reserves for unmoved item');
604
605
    @result = $dbh->selectrow_array('SELECT biblionumber FROM tmp_holdsqueue WHERE itemnumber = ?', undef, $itemnumber1);
606
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in tmp_holdsqueue for moved item');
607
608
    @result = $dbh->selectrow_array('SELECT biblionumber FROM tmp_holdsqueue WHERE itemnumber = ?', undef, $itemnumber2);
609
    is($result[0], $source_biblionumber, 'Correct biblionumber in tmp_holdsqueue for unmoved item');
610
611
    @result = $dbh->selectrow_array('SELECT biblionumber FROM hold_fill_targets WHERE itemnumber = ?', undef, $itemnumber1);
612
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in hold_fill_targets for moved item');
613
614
    @result = $dbh->selectrow_array('SELECT biblionumber FROM hold_fill_targets WHERE itemnumber = ?', undef, $itemnumber2);
615
    is($result[0], $source_biblionumber, 'Correct biblionumber in hold_fill_targets for unmoved item');
616
617
    @result = $dbh->selectrow_array('SELECT biblionumber FROM linktracker WHERE itemnumber = ?', undef, $itemnumber1);
618
    is($result[0], $target_biblio->biblionumber, 'Correct biblionumber in linktracker for moved item');
619
620
    @result = $dbh->selectrow_array('SELECT biblionumber FROM linktracker WHERE itemnumber = ?', undef, $itemnumber2);
621
    is($result[0], $source_biblionumber, 'Correct biblionumber in linktracker for unmoved item');
622
623
    $schema->storage->txn_rollback;
624
};

Return to bug 22690