Bugzilla – Attachment 108788 Details for
Bug 18501
Automatic refunds need protection from failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18501: (follow-up) Use t::lib::Dates::compare in tests
Bug-18501-follow-up-Use-tlibDatescompare-in-tests.patch (text/plain), 1.52 KB, created by
Martin Renvoize
on 2020-08-21 09:26:32 UTC
(
hide
)
Description:
Bug 18501: (follow-up) Use t::lib::Dates::compare in tests
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-08-21 09:26:32 UTC
Size:
1.52 KB
patch
obsolete
>From 005daca44970a760e779e6d72c5767dfce13295d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 21 Aug 2020 10:21:35 +0100 >Subject: [PATCH] Bug 18501: (follow-up) Use t::lib::Dates::compare in tests > >--- > t/db_dependent/Koha/Items.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t >index 6140139c0c..bd2b6b013f 100644 >--- a/t/db_dependent/Koha/Items.t >+++ b/t/db_dependent/Koha/Items.t >@@ -118,13 +118,15 @@ subtest 'store' => sub { > Time::Fake->offset( $yesterday->epoch ); > $item->$field(1)->store; > $item->get_from_storage; >- is($item->$field_on, DateTime::Format::MySQL->format_datetime($yesterday), $field_on . " was set upon first truthy setting"); >+ is( t::lib::Dates::compare( $item->$field_on, $yesterday ), >+ 0, $field_on . " was set upon first truthy setting" ); > > # Update the field to a new 'true' value > Time::Fake->offset( $today->epoch ); > $item->$field(2)->store; > $item->get_from_storage; >- is($item->$field_on, DateTime::Format::MySQL->format_datetime($yesterday), $field_on . " was not updated upon second truthy setting"); >+ is( t::lib::Dates::compare( $item->$field_on, $yesterday ), >+ 0, $field_on . " was not updated upon second truthy setting" ); > > # Update the field to a new 'false' value > $item->$field(0)->store; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18501
:
108004
|
108005
|
108006
|
108121
|
108122
|
108123
|
108167
|
108168
|
108169
|
108170
|
108193
|
108194
|
108195
|
108243
|
108248
|
108249
|
108291
|
108292
|
108293
|
108294
|
108295
|
108296
|
108297
|
108298
|
108299
|
108300
|
108301
|
108482
|
108483
|
108484
|
108485
|
108486
|
108487
|
108488
|
108489
|
108490
|
108491
|
108492
|
108493
|
108494
|
108575
|
108576
|
108577
|
108578
|
108579
|
108580
|
108581
|
108582
|
108583
|
108584
|
108585
|
108586
|
108596
|
108597
|
108598
|
108599
|
108600
|
108601
|
108602
|
108603
|
108604
|
108605
|
108606
|
108607
|
108608
|
108610
|
108611
|
108612
|
108613
|
108614
|
108615
|
108616
|
108617
|
108618
|
108619
|
108620
|
108621
|
108717
|
108732
|
108738
|
108739
|
108740
|
108741
|
108784
|
108785
|
108786
|
108787
| 108788 |
108795
|
111295