Bugzilla – Attachment 108811 Details for
Bug 26270
XISBN.t is failing since today
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26270: Fix ThingISBN after a change in behaviour
Bug-26270-Fix-ThingISBN-after-a-change-in-behaviou.patch (text/plain), 1.05 KB, created by
Jonathan Druart
on 2020-08-21 12:02:08 UTC
(
hide
)
Description:
Bug 26270: Fix ThingISBN after a change in behaviour
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-21 12:02:08 UTC
Size:
1.05 KB
patch
obsolete
>From e6d7e5cc7506e94edc4efcb4468c6512b91c3498 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 21 Aug 2020 14:00:51 +0200 >Subject: [PATCH] Bug 26270: Fix ThingISBN after a change in behaviour > >This is just a guess! One of our tests is failing since today and we >don't modify anything in this area. >My guess is that the service is now returning the normalized version of >the ISBN >--- > C4/XISBN.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/XISBN.pm b/C4/XISBN.pm >index c28cc340b6..de9dc100fe 100644 >--- a/C4/XISBN.pm >+++ b/C4/XISBN.pm >@@ -106,6 +106,8 @@ sub get_xisbns { > next if $unique_xisbns->{ $response_data->{content} }; > $unique_xisbns->{ $response_data->{content} }++; > my $xbiblio= _get_biblio_from_xisbn($response_data->{content}); >+ next unless $xbiblio; >+ next if $xbiblio->{normalized_isbn} && $xbiblio->{normalized_isbn} eq $isbn; > push @xisbns, $xbiblio if $xbiblio && $xbiblio->{biblionumber} ne $biblionumber; > } > if ( wantarray ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26270
:
108811
|
108828
|
108874