Bugzilla – Attachment 108824 Details for
Bug 26069
Twitter share button leaks information to Twitter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26069: Pass correct URL to twitter
Bug-26069-Pass-correct-URL-to-twitter.patch (text/plain), 1.92 KB, created by
Jonathan Druart
on 2020-08-21 14:09:28 UTC
(
hide
)
Description:
Bug 26069: Pass correct URL to twitter
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-21 14:09:28 UTC
Size:
1.92 KB
patch
obsolete
>From 93d6f8bb1d2073941e60670250fd36c41db7d3d3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 21 Aug 2020 16:07:46 +0200 >Subject: [PATCH] Bug 26069: Pass correct URL to twitter > >We don't provide the url of the detail page so the twitter JS code >retrieve the current location, with the search terms. > >Test plan: >Do a search >Click on a result >Click on the twitter button and confirm that the link only contain >biblionumber=x in the parameter >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index f8dce1e0a1..b1fbc3feeb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1107,7 +1107,7 @@ > [% CASE "email" -%] > <div><a id="email" href="mailto:?subject=[% title |url %]&body=[% title |url %]%20([% current_url |url %])" title="Share by email"><i class="fa fa-envelope-o" aria-hidden="true"></i></a></div> > [% CASE "twitter" -%] >- <div><a id="twitter" href="https://twitter.com/share" class="twitter-share-button" data-count="none" data-text="[% title |url %]" data-lang="[% lang | html %]" title="Share on Twitter"><i class="fa fa-twitter" aria-hidden="true"></i></a></div> >+ <div><a id="twitter" href="https://twitter.com/share" class="twitter-share-button" data-count="none" data-text="[% title |url %]" data-url="[% current_url |url %]" data-lang="[% lang | html %]" title="Share on Twitter"><i class="fa fa-twitter" aria-hidden="true"></i></a></div> > [% END -%] > [% END %] > </div> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26069
:
108824
|
108832
|
109121
|
109206