From 2ca1458e9bbc46ace2d3dd020f3b74945b840030 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 19 Jun 2019 21:11:20 -0500
Subject: [PATCH] Bug 23166: Remove baskets_deletedorders code

This is never used.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 catalogue/ISBDdetail.pl        | 4 ----
 catalogue/MARCdetail.pl        | 4 ----
 catalogue/detail.pl            | 6 ------
 catalogue/imageviewer.pl       | 4 ----
 catalogue/labeledMARCdetail.pl | 4 ----
 catalogue/moredetail.pl        | 4 ----
 6 files changed, 26 deletions(-)

diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl
index 6999c0455f..8e1ea52caf 100755
--- a/catalogue/ISBDdetail.pl
+++ b/catalogue/ISBDdetail.pl
@@ -154,15 +154,11 @@ $template->param (
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl
index bd6341b590..eb9553331a 100755
--- a/catalogue/MARCdetail.pl
+++ b/catalogue/MARCdetail.pl
@@ -347,15 +347,11 @@ $template->param (
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index cda10b7c60..b0e6d2c07e 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -555,15 +555,11 @@ if ($StaffDetailItemSelection) {
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
@@ -578,6 +574,4 @@ $template->param (countorders => $count_orders_using_biblio);
 my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ;
 $template->param (countdeletedorders => $count_deletedorders_using_biblio);
 
-$template->param (basketsdeletedorders => \@baskets_deletedorders);
-
 output_html_with_http_headers $query, $cookie, $template->output;
diff --git a/catalogue/imageviewer.pl b/catalogue/imageviewer.pl
index 21151d6263..9efba1754a 100755
--- a/catalogue/imageviewer.pl
+++ b/catalogue/imageviewer.pl
@@ -90,15 +90,11 @@ $template->{VARS}->{'biblio'} = $biblio;
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
diff --git a/catalogue/labeledMARCdetail.pl b/catalogue/labeledMARCdetail.pl
index ead7b9aeed..8799a7f805 100755
--- a/catalogue/labeledMARCdetail.pl
+++ b/catalogue/labeledMARCdetail.pl
@@ -136,15 +136,11 @@ $template->param (
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep { $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl
index 13176493fe..ea18505b45 100755
--- a/catalogue/moredetail.pl
+++ b/catalogue/moredetail.pl
@@ -270,15 +270,11 @@ $template->{'VARS'}->{'searchid'} = $query->param('searchid');
 my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
 my @deletedorders_using_biblio;
 my @orders_using_biblio;
-my @baskets_deletedorders;
 
 foreach my $myorder (@allorders_using_biblio) {
     my $basket = $myorder->{'basketno'};
     if ((defined $myorder->{'datecancellationprinted'}) and  ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
         push @deletedorders_using_biblio, $myorder;
-        unless (grep{ $_ eq $basket } @baskets_deletedorders){
-            push @baskets_deletedorders,$myorder->{'basketno'};
-        }
     }
     else {
         push @orders_using_biblio, $myorder;
-- 
2.11.0