Bugzilla – Attachment 109362 Details for
Bug 26262
Paging on course reserves tables in OPAC is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26262: Remove wrong dom setting in course reserves (OPAC)
Bug-26262-Remove-wrong-dom-setting-in-course-reser.patch (text/plain), 1.82 KB, created by
Owen Leonard
on 2020-08-31 12:43:15 UTC
(
hide
)
Description:
Bug 26262: Remove wrong dom setting in course reserves (OPAC)
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-08-31 12:43:15 UTC
Size:
1.82 KB
patch
obsolete
>From f2adb7ef5e957cef833b74e12c64e0ad10482545 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 26 Aug 2020 12:41:47 -0300 >Subject: [PATCH] Bug 26262: Remove wrong dom setting in course reserves (OPAC) > >The current setting required pagination to be displayed. This was hidden >probably as a side effect of styling settings. But the docs are clear on >the fact that p and l are intended for displaying pagination controls >and table rows lenght information [1] > >As the course reserves datatable is not paginated, this needs to be >fixed properly by removing those controls in the configuration. This >patch does so. > >To test: >1. Have some course reserves >2. See them in the OPAC >=> FAIL: Some funky, misaligned pagination artifacts are displayed >3. Apply this patch and reload >=> SUCCESS: Things are back to normal! >4. Sign off :-D > >[1] https://datatables.net/examples/basic_init/dom.html > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >index 6149ce11e4..868fcbb195 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >@@ -72,7 +72,7 @@ > columns_settings = [% TablesSettings.GetColumns( 'opac', 'biblio-detail', 'course_reserves_table', 'json' ) | $raw %] > > KohaTable("#course_reserves_table", { >- "dom": '<"top"flp>rt<"clear">', >+ "dom": '<"top"f>rt<"clear">', > "sorting": [[ 1, "asc" ]], > "autoWidth": false, > "asColumnDefs": [ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26262
:
109189
|
109362
|
109363
|
109673
|
109831
|
109832
|
109989
|
109990