Bugzilla – Attachment 109368 Details for
Bug 17661
Differences in field ending (whitespace, punctuation) cause duplicate facets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17661: Trivial simplification using += operator
Bug-17661-Trivial-simplification-using--operator.patch (text/plain), 942 bytes, created by
Jonathan Druart
on 2020-08-31 13:26:08 UTC
(
hide
)
Description:
Bug 17661: Trivial simplification using += operator
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-08-31 13:26:08 UTC
Size:
942 bytes
patch
obsolete
>From 6eb1dc200c2458cf7ede56950171ed1771d1af39 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 31 Aug 2020 15:25:05 +0200 >Subject: [PATCH] Bug 17661: Trivial simplification using += operator > >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 3a1f4e560b..5509a5b4cb 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -781,7 +781,7 @@ sub _get_facet_from_result_set { > my $facet_value = $term->textContent; > $facet_value =~ s/\s*(?<!\p{Uppercase})[.\-,;]*\s*$//; > $facet_value =~ s/\Q$internal_sep\E/$sep/ if defined $sep; >- $facets->{ $facet_value } = ( defined $facets->{$facet_value} ) ? $facets->{ $facet_value } + $term->getAttribute( 'occur' ) : $term->getAttribute( 'occur' ); >+ $facets->{ $facet_value } += $term->getAttribute( 'occur' ); > } > > return $facets; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17661
:
57658
|
57659
|
68897
|
106637
|
108742
|
109117
|
109242
|
109259
|
109260
| 109368