@@ -, +, @@ =?UTF-8?q?critic=20violations=20in=20C4/Koha.pm?= - Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 1112, column 4. See page 199 of PBP. (Severity: 5) --- C4/Koha.pm | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) --- a/C4/Koha.pm +++ a/C4/Koha.pm @@ -112,7 +112,7 @@ sub slashifyDate { } # FIXME.. this should be moved to a MARC-specific module -sub subfield_is_koha_internal_p ($) { +sub subfield_is_koha_internal_p { my ($subfield) = @_; # We could match on 'lib' and 'tab' (and 'mandatory', & more to come!) @@ -471,7 +471,7 @@ sub getitemtypeimagesrc { } } -sub getitemtypeimagelocation($$) { +sub getitemtypeimagelocation { my ( $src, $image ) = @_; return '' if ( !$image ); @@ -630,7 +630,7 @@ sub GetPrinters { =cut -sub GetPrinter ($$) { +sub GetPrinter { my ( $query, $printers ) = @_; # get printer for this query from printers my $printer = $query->param('printer'); my %cookie = $query->cookie('userenv'); @@ -1109,7 +1109,7 @@ sub GetKohaAuthorisedValues { } return \%values; } else { - return undef; + return; } } @@ -1140,7 +1140,7 @@ sub GetKohaAuthorisedValuesFromField { } return \%values; } else { - return undef; + return; } } @@ -1242,7 +1242,7 @@ sub GetNormalizedISBN { $isbn =~ s/(.*)( \| )(.*)/$1/; return _isbn_cleanup($isbn); } - return undef unless $record; + return unless $record; if ($marcflavour eq 'UNIMARC') { @fields = $record->field('010'); @@ -1251,7 +1251,7 @@ sub GetNormalizedISBN { if ($isbn) { return _isbn_cleanup($isbn); } else { - return undef; + return; } } } @@ -1262,7 +1262,7 @@ sub GetNormalizedISBN { if ($isbn) { return _isbn_cleanup($isbn); } else { - return undef; + return; } } } @@ -1307,7 +1307,7 @@ sub GetNormalizedOCLCNumber { $oclc =~ s/\(OCoLC\)//; return $oclc; } else { - return undef; + return; } } } --