From 365c7695e8c17473a5a6bc675beab4548e73db3d Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 01:22:21 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm - "return" statement with explicit "undef" at line 57, column 2. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/Barcodes.pm | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/C4/Barcodes.pm b/C4/Barcodes.pm index 4a5fa19..25f03d0 100644 --- a/C4/Barcodes.pm +++ b/C4/Barcodes.pm @@ -54,7 +54,7 @@ sub initial { return '0000001'; } sub width { - return undef; + return; } sub process_head { # (self,head,whole,specific) my $self = shift; @@ -128,7 +128,7 @@ sub next_value { my ($head,$incr,$tail) = $self->parse($max); # for incremental, you'd get ('',the_whole_barcode,'') unless (defined $incr) { warn "No incrementing part of barcode ($max) returned by parse."; - return undef; + return; } my $x = length($incr); # number of digits $incr =~ /^9+$/ and $x++; # if they're all 9's, we need an extra. @@ -144,17 +144,17 @@ sub next_value { return $next_value; } sub next { - my $self = shift or return undef; + my $self = shift or return; (@_) and $self->{next} = shift; return $self->{next}; } sub previous { - my $self = shift or return undef; + my $self = shift or return; (@_) and $self->{previous} = shift; return $self->{previous}; } sub serial { - my $self = shift or return undef; + my $self = shift or return; (@_) and $self->{serial} = shift; return $self->{serial}; } @@ -190,11 +190,11 @@ sub new { $autoBarcodeType =~ s/^.*:://; # in case we get C4::Barcodes::incremental, we just want 'incremental' unless ($autoBarcodeType) { carp "No autoBarcode format found."; - return undef; + return; } unless (defined $types->{$autoBarcodeType}) { carp "The autoBarcode format '$autoBarcodeType' is unrecognized."; - return undef; + return; } carp "autoBarcode format = $autoBarcodeType" if $debug; my $self; @@ -225,7 +225,7 @@ sub new { return $self; } carp "Failed new C4::Barcodes::$autoBarcodeType"; - return undef; + return; } sub new_object { -- 1.7.7.3