From 6471bc714d98e0232dc730a724a2e79e2325e6d2 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 02:02:26 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm - Subroutine prototypes used at line 161, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/Serials.pm | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 58b6078..c37cc35 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -158,7 +158,7 @@ After this function, don't forget to execute it by using $sth->execute($subscrip =cut -sub GetSubscriptionHistoryFromSubscriptionId() { +sub GetSubscriptionHistoryFromSubscriptionId { my $dbh = C4::Context->dbh; my $query = qq| SELECT * @@ -178,7 +178,7 @@ $sth = $dbh->prepare($query). =cut -sub GetSerialStatusFromSerialId() { +sub GetSerialStatusFromSerialId { my $dbh = C4::Context->dbh; my $query = qq| SELECT status @@ -1109,7 +1109,7 @@ $nextexepected = { =cut -sub GetNextExpected($) { +sub GetNextExpected { my ($subscriptionid) = @_; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare('SELECT serialid, planneddate FROM serial WHERE subscriptionid=? AND status=?'); @@ -1144,7 +1144,7 @@ returns 0 =cut -sub ModNextExpected($$) { +sub ModNextExpected { my ( $subscriptionid, $date ) = @_; my $dbh = C4::Context->dbh; @@ -2191,7 +2191,7 @@ Return 0 if periodicity==0 =cut -sub GetNextDate(@) { +sub GetNextDate { my ( $planneddate, $subscription ) = @_; my @irreg = split( /\,/, $subscription->{irregularity} ); -- 1.7.7.3