From 64305a6fd334459f1af71830328b75604b7e1dd5 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 02:37:09 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm Subroutine prototypes used at line 251, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 287, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 317, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/SQLHelper.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/SQLHelper.pm b/C4/SQLHelper.pm index 703c28d..21f5fa1 100644 --- a/C4/SQLHelper.pm +++ b/C4/SQLHelper.pm @@ -248,7 +248,7 @@ Get the Primary Key field names of the table =cut -sub GetPrimaryKeys($) { +sub GetPrimaryKeys { my $tablename=shift; my $hash_columns=_get_columns($tablename); return grep { $hash_columns->{$_}->{'Key'} =~/PRI/i} keys %$hash_columns; @@ -284,7 +284,7 @@ With =cut -sub _get_columns($) { +sub _get_columns { my ($tablename) = @_; unless ( exists( $hashref->{$tablename} ) ) { my $dbh = C4::Context->dbh; @@ -314,7 +314,7 @@ If it is not for research purpose, filter primary keys =cut -sub _filter_columns ($$;$) { +sub _filter_columns { my ($tablename,$research, $filtercolumns)=@_; if ($filtercolumns){ return (@$filtercolumns); -- 1.7.7.3