From 290788e3df23d9d3d72b3af1ffb0a20c5b21fed4 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 05:09:10 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm "return" statement with explicit "undef" at line 234, column 5. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 256, column 9. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart --- C4/BackgroundJob.pm | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/BackgroundJob.pm b/C4/BackgroundJob.pm index efea3f5..6830565 100644 --- a/C4/BackgroundJob.pm +++ b/C4/BackgroundJob.pm @@ -231,7 +231,7 @@ if the job status is not 'completed'. sub results { my $self = shift; - return undef unless $self->{'status'} eq 'completed'; + return unless $self->{'status'} eq 'completed'; return $self->{'results'}; } @@ -253,7 +253,7 @@ sub fetch { my $session = get_session($sessionID); my $prefix = "job_$jobID"; unless (defined $session->param($prefix)) { - return undef; + return; } my $self = $session->param($prefix); bless $self, $class; -- 1.7.7.3