From 11ac2393edef67c1d06a26f414b84dbd2fd6e01a Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 8 Sep 2020 16:54:19 +0200 Subject: [PATCH] Bug 26407: fix query in 'title exists' in `search_for_data_inconsistencies.pl` Bug 23871 added check for 'title exists' to `search_for_data_inconsistencies.pl`. There is a typo in DBIx query to create or : hashref instead of arrayref. Test plan : 1) Change title of biblio record XXX in SQL : UPDATE biblio SET title = '' WHERE biblionumber=XXX 2) Change title of biblio record YYY in SQL : UPDATE biblio SET title = NULL WHERE biblionumber=YYY 3) Run misc/maintenance/search_for_data_inconsistencies.pl 4) Check you see both records --- misc/maintenance/search_for_data_inconsistencies.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl index 8f4014529e..433f668040 100755 --- a/misc/maintenance/search_for_data_inconsistencies.pl +++ b/misc/maintenance/search_for_data_inconsistencies.pl @@ -196,7 +196,12 @@ use C4::Biblio; } { - my $biblios = Koha::Biblios->search({ -or => { title => undef, title => '' }}); + my $biblios = Koha::Biblios->search({ + -or => [ + title => '', + title => undef, + ] + }); if ( $biblios->count ) { my ( $title_tag, $title_subtag ) = C4::Biblio::GetMarcFromKohaField( 'biblio.title' ); my $title_field = $title_tag // ''; -- 2.27.0