From 1a7da7192a6569f3ac04797ad9a26da05e46daba Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 05:02:00 +1200 Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm Bareword file handle opened at line 80, column 9. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 80, column 9. See page 207 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart http://perldoc.perl.org/functions/open.html For three or more arguments if MODE is |- , the filename is interpreted as a command to which output is to be piped, and if MODE is -| , the filename is interpreted as a command that pipes output to us. I --- C4/Print.pm | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/C4/Print.pm b/C4/Print.pm index 12aa107..6683119 100644 --- a/C4/Print.pm +++ b/C4/Print.pm @@ -67,9 +67,11 @@ sub NetworkPrint { # set the queue to "file" (or " file", if real queues aren't allowed # to have spaces in them). Or perhaps if $queue eq "" and # $env->{file} ne "", then that should mean "print to $env->{file}". + + my $fh; if ( $queue eq "" || $queue eq 'nulllp' ) { return; - #open( PRINTER, ">/tmp/kohaiss" ); + #open( $fh, ">/tmp/kohaiss" ); } else { @@ -77,15 +79,15 @@ sub NetworkPrint { # This is a reasonable assumption, but only because every other # printing package has a wrapper script called 'lpr'. It'd still # be better to be able to customize this. - open( PRINTER, "| lpr -P $queue > /dev/null" ) + open( $fh, "-|", "lpr -P $queue > /dev/null" ) or die "Couldn't write to queue:$queue!\n"; } # print $queue; #open (FILE,">/tmp/$file"); - print PRINTER $text; - print PRINTER "\r\n" x 7 ; - close PRINTER; + print $fh $text; + print $fh "\r\n" x 7 ; + close $fh; #system("lpr /tmp/$file"); } -- 1.7.7.3