From 62a0bb9a93838f5a3598b3800baea46a114bc02e Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 04:54:11 +1200 Subject: [PATCH 1/1] Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings Subroutine prototypes used at line 561, column 1. See page 194 of PBP. (Severity: 5) Bareword file handle opened at line 606, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 606, column 5. See page 207 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart This patch reintroduces 'use warnings' in C4/Auth.pm. Keep attentive to new warning messages in your log --- C4/Auth.pm | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index b6dc2f5..361079b 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -18,7 +18,7 @@ package C4::Auth; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -#use warnings; FIXME - Bug 2505 +use warnings; use Digest::MD5 qw(md5_base64); use Storable qw(thaw freeze); use URI::Escape; @@ -129,6 +129,7 @@ my $SEARCH_HISTORY_INSERT_SQL =<>/tmp/sessionlog" or warn "ERROR: Cannot append to /tmp/sessionlog"; - printf L join("\n",@_); - close L; + open my $fh, '>>', "/tmp/sessionlog" or warn "ERROR: Cannot append to /tmp/sessionlog"; + printf $fh join("\n",@_); + close $fh; } sub checkauth { -- 1.7.7.3