Bugzilla – Attachment 109935 Details for
Bug 26330
jQueryUI tabs don't work with non-Latin-1 characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints
Bug-26330-Change-encoding-of-text-used-as-tab-trig.patch (text/plain), 2.79 KB, created by
Julian Maurice
on 2020-09-11 11:55:04 UTC
(
hide
)
Description:
Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2020-09-11 11:55:04 UTC
Size:
2.79 KB
patch
obsolete
>From 29f9f983b116b881d8c2e0e99166dd752a685a60 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 1 Sep 2020 11:51:25 +0000 >Subject: [PATCH] Bug 26330: Change encoding of text used as tab triggers in > MARC subfield constraints >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch changes the encoding of the data being used to define >jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug >prevents non-Latin-1 characters from being used when defining tab >controls. Using Template:Toolkit's "uri" filter converts the data to >usable characters. > >To test, apply the patch and go to Administration -> MARC frameworks -> >MARC structure -> tag 952 -> Edit subfields. > >- Under the "New" tab, add a subfield code which is outside the basic > Latin character set, e.g. £, §, æ. >- Save changes. >- Edit any subfield code to load the subfield constraints page again. >- Test that the subfield code tabs work correctly: Clicking each tab > should load only the corresponding panel. >- Test a variety of tabs including the one you created with the > non-Latin character. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > .../prog/en/modules/admin/marc_subfields_structure.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >index 461ca663d6..df5395cedf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >@@ -49,9 +49,9 @@ > <ul> > [% FOREACH loo IN loop %] > [% IF ( loo.new_subfield ) %] >- <li><a href="#sub[% loo.urisubfieldcode | html_entity %]field" title="[% loo.liblibrarian | html_entity %]">New</a></li> >+ <li><a href="#sub[% loo.urisubfieldcode | uri %]field" title="[% loo.liblibrarian | html_entity %]">New</a></li> > [% ELSE %] >- <li><a href="#sub[% loo.urisubfieldcode | html_entity %]field" title="[% loo.liblibrarian | html_entity %]"> >+ <li><a href="#sub[% loo.urisubfieldcode | uri %]field" title="[% loo.liblibrarian | html_entity %]"> > [% loo.subfieldcode | html %] > </a></li> > [% END %] >@@ -59,7 +59,7 @@ > </ul> > > [% FOREACH loo IN loop %] >- <div class="constraints" id="sub[% loo.urisubfieldcode | html %]field"> >+ <div class="constraints" id="sub[% loo.urisubfieldcode | uri %]field"> > > <div id="basic[% loo.urisubfieldcode | html %]" class="contraints"> > <fieldset class="rows"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26330
:
109386
|
109422
|
109684
| 109935