Bugzilla – Attachment 110628 Details for
Bug 26512
Display issue with buttons for OPAC checkout note
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26512: Display issue with buttons for OPAC checkout note
Bug-26512-Display-issue-with-buttons-for-OPAC-chec.patch (text/plain), 2.74 KB, created by
Katrin Fischer
on 2020-09-23 20:37:10 UTC
(
hide
)
Description:
Bug 26512: Display issue with buttons for OPAC checkout note
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-09-23 20:37:10 UTC
Size:
2.74 KB
patch
obsolete
>From 362b25bf02cd67369b7d2fb88f1109e87dab414f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 23 Sep 2020 11:48:00 +0000 >Subject: [PATCH] Bug 26512: Display issue with buttons for OPAC checkout note > >This patch adds the correct Bootstrap 4 class to the buttons for >submitting checkout notes in the OPAC. > >The markup has been updated to use <button> instead of <a> because of a >style conflict with jQueryUI's CSS. > >To test, apply the patch and enable the AllowCheckoutNotes system >preference. > >- Log in to the OPAC as a patron with checkouts. >- On the "Your summary" page, enter some text into a field in the > "Notes" column of the checkouts table. >- Upon typing in the field a button should appear, "Submit note." >- The button should be styled as a green button. >- Submit the note. >- Make a change to the text in the field. A button should appear, > "Submit changes." It should also be styled correctly. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 13cd1843ee..86a68cb023 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -404,8 +404,8 @@ > [% IF ( Koha.Preference('AllowCheckoutNotes') ) %] > <td class="note"> > <input type="text" name="note" data-issue_id="[% ISSUE.issue_id | html %]" data-origvalue="[% ISSUE.note | html %]" value="[% ISSUE.note | html %]" readonly> >- <a class="btn js_submitnote" id="save_[% ISSUE.issue_id | html %]" style="display:none;">Submit note</a> >- <a class="btn nonjs_submitnote" href="/cgi-bin/koha/opac-issue-note.pl?issue_id=[% ISSUE.issue_id | url %]">Edit / Create note</a> >+ <button type="button" class="btn btn-primary btn-sm js_submitnote" id="save_[% ISSUE.issue_id | html %]" style="display:none;">Submit note</button> >+ <button type="button" class="btn btn-primary btn-sm nonjs_submitnote" href="/cgi-bin/koha/opac-issue-note.pl?issue_id=[% ISSUE.issue_id | url %]">Edit / Create note</button> > </td> > [% END %] > </tr> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26512
:
110599
|
110624
| 110628