From 8335e2b3e11e279e6a09896ed154a92c5b503e5a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 17 Sep 2020 11:43:44 +0000 Subject: [PATCH] Bug 25265: Unit tests Content-Type: text/plain; charset=utf-8 These cover Koha::SearchEngine::Indexer and ensure that all calls in the code are routed correctly to the expected search engine Bug 25265: (follow-up) Skip tests if elastic not configured Signed-off-by: Bob Bennhoff Signed-off-by: Marcel de Rooy --- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 9 ++ t/db_dependent/Koha/SearchEngine/Indexer.t | 156 +++++++++++++++++++++ 2 files changed, 165 insertions(+) create mode 100755 t/db_dependent/Koha/SearchEngine/Indexer.t diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t index 0b610bd79c..cd93fe960b 100755 --- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t +++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t @@ -29,6 +29,13 @@ my $schema = Koha::Database->schema(); use_ok('Koha::SearchEngine::Elasticsearch::Indexer'); +SKIP: { + + eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; }; + + skip 'Elasticsearch configuration not available', 1 + if $@; + subtest 'create_index() tests' => sub { plan tests => 6; my $se = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' ); @@ -71,3 +78,5 @@ subtest 'create_index() tests' => sub { 'Dropping the index' ); }; + +} diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t new file mode 100755 index 0000000000..abcbc9a9cb --- /dev/null +++ b/t/db_dependent/Koha/SearchEngine/Indexer.t @@ -0,0 +1,156 @@ +#!/usr/bin/perl + +# Tests for Koha/SearchEngine/Search + +use Modern::Perl; + +use Test::More tests => 2; +use Test::Warn; + +use MARC::Field; +use MARC::Record; +use Test::MockModule; +use Test::MockObject; + +use t::lib::Mocks; + +#use C4::Biblio qw//; +use C4::AuthoritiesMarc; +use C4::Biblio; +use C4::Circulation; +use Koha::Database; +use Koha::SearchEngine::Indexer; + +use t::lib::TestBuilder; +use t::lib::Mocks; + +my $schema = Koha::Database->new->schema; +my $builder = t::lib::TestBuilder->new; + +$schema->storage->txn_begin; + +subtest 'Test indexer object creation' => sub { + plan tests => 6; + + t::lib::Mocks::mock_preference( 'SearchEngine', 'Zebra' ); + my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX }); + is( ref $indexer, 'Koha::SearchEngine::Zebra::Indexer', 'We get the correct class for Zebra biblios'); + $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::AUTHORITIES_INDEX }); + is( ref $indexer, 'Koha::SearchEngine::Zebra::Indexer', 'We get the correct class for Zebra authorities'); + + t::lib::Mocks::mock_preference( 'SearchEngine', 'Elasticsearch' ); + + SKIP: { + + eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; }; + + skip 'Elasticsearch configuration not available', 4 + if $@; + + $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX }); + is( ref $indexer, 'Koha::SearchEngine::Elasticsearch::Indexer', 'We get the correct class for Elasticsearch biblios'); + ok( $indexer->index_name =~ /biblios$/, "The index is set correctly for biblios"); + $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::AUTHORITIES_INDEX }); + is( ref $indexer, 'Koha::SearchEngine::Elasticsearch::Indexer', 'We get the correct class for Elasticsearch authorities'); + ok( $indexer->index_name =~ /authorities$/, "The index is set correctly for authorities"); + + } +}; + +subtest 'Test indexer calls' => sub { + plan tests => 24; + + my @engines = ('Zebra'); + eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; }; + push @engines, 'Elasticsearch' unless $@; + SKIP: { + skip 'Elasticsearch configuration not available', 12 + if scalar @engines == 1; + } + + for my $engine ( @engines ){ + t::lib::Mocks::mock_preference( 'SearchEngine', $engine ); + my $mock_index = Test::MockModule->new("Koha::SearchEngine::".$engine."::Indexer"); + + my $biblionumber1 = $builder->build_sample_biblio()->biblionumber; + my $biblionumber2 = $builder->build_sample_biblio()->biblionumber; + + my $mock_zebra = Test::MockModule->new("Koha::SearchEngine::Zebra::Indexer"); + $mock_zebra->mock( ModZebra => sub { warn "ModZebra"; } ); + my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX }); + warnings_are{ + $indexer->index_records([$biblionumber1,$biblionumber1],"specialUpdate","biblioserver",undef); + } ["ModZebra","ModZebra"],"ModZebra called for each record being indexed for $engine"; + + $mock_index->mock( index_records => sub { + warn $engine; + my ($package, undef, undef) = caller; + warn $package; + }); + + my $auth = MARC::Record->new; + my $authid; + warnings_are{ + $authid = AddAuthority( $auth, undef, 'TOPIC_TERM' ); + } [$engine,"C4::AuthoritiesMarc"], "index_records is called for $engine is called when adding authority"; + + warnings_are{ + $authid = DelAuthority({ authid => $authid }); + } [$engine,"C4::AuthoritiesMarc"], "index_records is called for $engine is called when adding authority"; + + my $biblio; + my $biblio2; + warnings_are{ + $biblio = $builder->build_sample_biblio(); + $biblio2 = $builder->build_sample_biblio(); + } [$engine,'C4::Biblio',$engine,'C4::Biblio'], "index_records is called for $engine when adding a biblio (ModBiblioMarc)"; + + + my $item; + my $item2; + warnings_are{ + $item = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + $item2 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + } [$engine,"Koha::Item",$engine,"Koha::Item"], "index_records is called for $engine when adding an item (Item->store)"; + warnings_are{ + $item->store({ skip_modzebra_update => 1 }); + } undef, "index_records is not called for $engine when adding an item (Item->store) if skip_modzebra_update passed"; + + $builder->build({ + source => 'Branchtransfer', + value => { + itemnumber => $item->itemnumber, + datearrived => undef} + }); + warnings_are{ + LostItem( $item->itemnumber, "tests"); + } [$engine,"Koha::Item"], "index_records is called for $engine when calling LostItem and transfer exists"; + $builder->build({ + source => 'Branchtransfer', + value => { + itemnumber => $item2->itemnumber, + datearrived => undef} + }); + warnings_are{ + LostItem( $item->itemnumber, "tests", undef, { skip_modzebra_update => 1 }); + } undef, "index_records is not called for $engine when calling LostItem and transfer exists if skip_modzebra_update"; + + warnings_are{ + $item->delete(); + } [$engine,"Koha::Item"], "index_records is called for $engine when deleting an item (Item->delete)"; + warnings_are{ + $item2->delete({ skip_modzebra_update => 1 }); + } undef, "index_records is not called for $engine when adding an item (Item->store) if skip_modzebra_update passed"; + + warnings_are{ + DelBiblio( $biblio->biblionumber ); + } [$engine, "C4::Biblio"], "index_records is called for $engine when calling DelBiblio"; + warnings_are{ + DelBiblio( $biblio->biblionumber, { skip_record_index =>1 }); + } undef, "index_records is not called for $engine when calling DelBiblio if skip_record_index passed"; + + } + +}; + +$schema->storage->txn_rollback; -- 2.11.0