From 29e70ef3d3055e199de1dfbfe583e9114d6407fc Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 13 Jul 2012 11:50:04 +1000 Subject: [PATCH 1/1] Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm) Patch introduces a check for C4::Context->userenv in Letters.pm, so that script doesn't fail when it calls to C4::Context->userenv->{branch}, when run from shell. Without the check, Advanced Notices, Item Due, and Overdues fail to generate. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall --- C4/Letters.pm | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/C4/Letters.pm b/C4/Letters.pm index b366fbc..b17cb08 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -120,7 +120,9 @@ my %letter; sub getletter { my ( $module, $code, $branchcode ) = @_; - if (C4::Context->preference('IndependantBranches') && $branchcode){ + if ( C4::Context->preference('IndependantBranches') + and $branchcode + and C4::Context->userenv ) { $branchcode = C4::Context->userenv->{'branch'}; } -- 1.7.7.3